Commit ddf98e6d authored by Thomas Meyer's avatar Thomas Meyer Committed by David S. Miller

ll_temac: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a1de2219
...@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev) ...@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev)
struct sk_buff *skb; struct sk_buff *skb;
int i; int i;
lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL); lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL);
if (!lp->rx_skb) { if (!lp->rx_skb) {
dev_err(&ndev->dev, dev_err(&ndev->dev,
"can't allocate memory for DMA RX buffer\n"); "can't allocate memory for DMA RX buffer\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment