Commit deae6e3a authored by Matthew Gerlach's avatar Matthew Gerlach Committed by Greg Kroah-Hartman

fpga: dfl: fix bug in port reset handshake

[ Upstream commit 8614afd6 ]

When putting the port in reset, driver must wait for the soft reset
acknowledgment bit instead of the soft reset bit.

Fixes: 47c1b19c (fpga: dfl: afu: add port ops support)
Signed-off-by: default avatarMatthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: default avatarXu Yilun <yilun.xu@intel.com>
Acked-by: default avatarWu Hao <hao.wu@intel.com>
Reviewed-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarMoritz Fischer <mdf@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 060a740b
...@@ -79,7 +79,8 @@ static int port_disable(struct platform_device *pdev) ...@@ -79,7 +79,8 @@ static int port_disable(struct platform_device *pdev)
* on this port and minimum soft reset pulse width has elapsed. * on this port and minimum soft reset pulse width has elapsed.
* Driver polls port_soft_reset_ack to determine if reset done by HW. * Driver polls port_soft_reset_ack to determine if reset done by HW.
*/ */
if (readq_poll_timeout(base + PORT_HDR_CTRL, v, v & PORT_CTRL_SFTRST, if (readq_poll_timeout(base + PORT_HDR_CTRL, v,
v & PORT_CTRL_SFTRST_ACK,
RST_POLL_INVL, RST_POLL_TIMEOUT)) { RST_POLL_INVL, RST_POLL_TIMEOUT)) {
dev_err(&pdev->dev, "timeout, fail to reset device\n"); dev_err(&pdev->dev, "timeout, fail to reset device\n");
return -ETIMEDOUT; return -ETIMEDOUT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment