Commit df88005b authored by Marek Vasut's avatar Marek Vasut Committed by Shawn Guo

soc: imx: gpcv2: Assert reset before ungating clock

In case the power domain clock are ungated before the reset is asserted,
the system might freeze completely. This is likely due to a device is an
undefined state being attached to bus, which sporadically leads to a bus
hang. Assert the reset before the clock are enabled to assure the device
is in defined state before being attached to bus.

Fixes: fe58c887 ("soc: imx: gpcv2: add support for optional resets")
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Reviewed-by: default avatarFabio Estevam <festevam@denx.de>
Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent e7406f86
...@@ -335,6 +335,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) ...@@ -335,6 +335,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
} }
} }
reset_control_assert(domain->reset);
/* Enable reset clocks for all devices in the domain */ /* Enable reset clocks for all devices in the domain */
ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks);
if (ret) { if (ret) {
...@@ -342,7 +344,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) ...@@ -342,7 +344,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
goto out_regulator_disable; goto out_regulator_disable;
} }
reset_control_assert(domain->reset); /* delays for reset to propagate */
udelay(5);
if (domain->bits.pxx) { if (domain->bits.pxx) {
/* request the domain to power up */ /* request the domain to power up */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment