Commit e00e57ef authored by Kenji Kaneshige's avatar Kenji Kaneshige Committed by Greg Kroah-Hartman

[PATCH] shpchp: replace pci_find_slot() with pci_get_slot()

This patch replaces pci_find_slot() with pci_get_slot() in the SHPCHP
driver. This enables SHPCHP driver to work on multiple PCI segment
systems.
Signed-off-by: default avatarKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2555f7bd
...@@ -89,10 +89,11 @@ int shpchp_configure_device(struct slot *p_slot) ...@@ -89,10 +89,11 @@ int shpchp_configure_device(struct slot *p_slot)
struct pci_bus *parent = p_slot->ctrl->pci_dev->subordinate; struct pci_bus *parent = p_slot->ctrl->pci_dev->subordinate;
int num, fn; int num, fn;
dev = pci_find_slot(p_slot->bus, PCI_DEVFN(p_slot->device, 0)); dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, 0));
if (dev) { if (dev) {
err("Device %s already exists at %x:%x, cannot hot-add\n", err("Device %s already exists at %x:%x, cannot hot-add\n",
pci_name(dev), p_slot->bus, p_slot->device); pci_name(dev), p_slot->bus, p_slot->device);
pci_dev_put(dev);
return -EINVAL; return -EINVAL;
} }
...@@ -103,12 +104,13 @@ int shpchp_configure_device(struct slot *p_slot) ...@@ -103,12 +104,13 @@ int shpchp_configure_device(struct slot *p_slot)
} }
for (fn = 0; fn < 8; fn++) { for (fn = 0; fn < 8; fn++) {
if (!(dev = pci_find_slot(p_slot->bus, dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, fn));
PCI_DEVFN(p_slot->device, fn)))) if (!dev)
continue; continue;
if ((dev->class >> 16) == PCI_BASE_CLASS_DISPLAY) { if ((dev->class >> 16) == PCI_BASE_CLASS_DISPLAY) {
err("Cannot hot-add display device %s\n", err("Cannot hot-add display device %s\n",
pci_name(dev)); pci_name(dev));
pci_dev_put(dev);
continue; continue;
} }
if ((dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) || if ((dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) ||
...@@ -124,18 +126,21 @@ int shpchp_configure_device(struct slot *p_slot) ...@@ -124,18 +126,21 @@ int shpchp_configure_device(struct slot *p_slot)
} }
if (busnr >= end) { if (busnr >= end) {
err("No free bus for hot-added bridge\n"); err("No free bus for hot-added bridge\n");
pci_dev_put(dev);
continue; continue;
} }
child = pci_add_new_bus(parent, dev, busnr); child = pci_add_new_bus(parent, dev, busnr);
if (!child) { if (!child) {
err("Cannot add new bus for %s\n", err("Cannot add new bus for %s\n",
pci_name(dev)); pci_name(dev));
pci_dev_put(dev);
continue; continue;
} }
child->subordinate = pci_do_scan_bus(child); child->subordinate = pci_do_scan_bus(child);
pci_bus_size_bridges(child); pci_bus_size_bridges(child);
} }
program_fw_provided_values(dev); program_fw_provided_values(dev);
pci_dev_put(dev);
} }
pci_bus_assign_resources(parent); pci_bus_assign_resources(parent);
...@@ -149,17 +154,19 @@ int shpchp_unconfigure_device(struct slot *p_slot) ...@@ -149,17 +154,19 @@ int shpchp_unconfigure_device(struct slot *p_slot)
int rc = 0; int rc = 0;
int j; int j;
u8 bctl = 0; u8 bctl = 0;
struct pci_bus *parent = p_slot->ctrl->pci_dev->subordinate;
dbg("%s: bus/dev = %x/%x\n", __FUNCTION__, p_slot->bus, p_slot->device); dbg("%s: bus/dev = %x/%x\n", __FUNCTION__, p_slot->bus, p_slot->device);
for (j=0; j<8 ; j++) { for (j=0; j<8 ; j++) {
struct pci_dev* temp = pci_find_slot(p_slot->bus, struct pci_dev* temp = pci_get_slot(parent,
(p_slot->device << 3) | j); (p_slot->device << 3) | j);
if (!temp) if (!temp)
continue; continue;
if ((temp->class >> 16) == PCI_BASE_CLASS_DISPLAY) { if ((temp->class >> 16) == PCI_BASE_CLASS_DISPLAY) {
err("Cannot remove display device %s\n", err("Cannot remove display device %s\n",
pci_name(temp)); pci_name(temp));
pci_dev_put(temp);
continue; continue;
} }
if (temp->hdr_type == PCI_HEADER_TYPE_BRIDGE) { if (temp->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
...@@ -167,10 +174,12 @@ int shpchp_unconfigure_device(struct slot *p_slot) ...@@ -167,10 +174,12 @@ int shpchp_unconfigure_device(struct slot *p_slot)
if (bctl & PCI_BRIDGE_CTL_VGA) { if (bctl & PCI_BRIDGE_CTL_VGA) {
err("Cannot remove display device %s\n", err("Cannot remove display device %s\n",
pci_name(temp)); pci_name(temp));
pci_dev_put(temp);
continue; continue;
} }
} }
pci_remove_bus_device(temp); pci_remove_bus_device(temp);
pci_dev_put(temp);
} }
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment