Commit e0299908 authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomi Valkeinen

video: fbdev: pxafb: potential NULL dereference on error

If we "goto out;" then it calls display_timings_release(timings);
Since "timings" is NULL, that's going to oops.  Just return directly.

Fixes: 420a4882 ('video: fbdev: pxafb: initial devicetree conversion')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 53d73a0a
...@@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, ...@@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
timings = of_get_display_timings(disp); timings = of_get_display_timings(disp);
if (!timings) if (!timings)
goto out; return -EINVAL;
ret = -ENOMEM; ret = -ENOMEM;
info->modes = kmalloc_array(timings->num_timings, info->modes = kmalloc_array(timings->num_timings,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment