Commit e0df7e1f authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

checkpatch: avoid "spaces required around that ':'" false positive

Since commit 1f65f947 ("checkpatch: add checks for question mark and
colon spacing") back in 2008, checkpatch has reported false positive for
asm volatile uses of "::" checkpatch thinks colons should always have
spaces around it.

Add an exception for colons with colons on either side for this valid asm
volatile (and c++) use.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarYehuda Yitschak <yehuday@marvell.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 323b267f
...@@ -3845,6 +3845,14 @@ sub process { ...@@ -3845,6 +3845,14 @@ sub process {
$ok = 1; $ok = 1;
} }
# for asm volatile statements
# ignore a colon with another
# colon immediately before or after
if (($op eq ':') &&
($ca =~ /:$/ || $cc =~ /^:/)) {
$ok = 1;
}
# messages are ERROR, but ?: are CHK # messages are ERROR, but ?: are CHK
if ($ok == 0) { if ($ok == 0) {
my $msg_type = \&ERROR; my $msg_type = \&ERROR;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment