Commit e0e29b68 authored by Kees Cook's avatar Kees Cook Committed by John W. Linville

b43: stop format string leaking into error msgs

The module parameter "fwpostfix" is userspace controllable, unfiltered,
and is used to define the firmware filename. b43_do_request_fw() populates
ctx->errors[] on error, containing the firmware filename. b43err()
parses its arguments as a format string. For systems with b43 hardware,
this could lead to a uid-0 to ring-0 escalation.

CVE-2013-2852
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 5efac949
...@@ -2458,7 +2458,7 @@ static void b43_request_firmware(struct work_struct *work) ...@@ -2458,7 +2458,7 @@ static void b43_request_firmware(struct work_struct *work)
for (i = 0; i < B43_NR_FWTYPES; i++) { for (i = 0; i < B43_NR_FWTYPES; i++) {
errmsg = ctx->errors[i]; errmsg = ctx->errors[i];
if (strlen(errmsg)) if (strlen(errmsg))
b43err(dev->wl, errmsg); b43err(dev->wl, "%s", errmsg);
} }
b43_print_fw_helptext(dev->wl, 1); b43_print_fw_helptext(dev->wl, 1);
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment