Commit e15ba45d authored by Oleg Drokin's avatar Oleg Drokin Committed by Greg Kroah-Hartman

staging/lustre/llite: Fix style vs open parenthesis alignment

This mostly fixes checkpatch complaints about
"Alignment should match open parenthesis"
Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 82ddecfe
...@@ -183,8 +183,7 @@ static int ll_ddelete(const struct dentry *de) ...@@ -183,8 +183,7 @@ static int ll_ddelete(const struct dentry *de)
int ll_d_init(struct dentry *de) int ll_d_init(struct dentry *de)
{ {
CDEBUG(D_DENTRY, "ldd on dentry %pd (%p) parent %p inode %p refc %d\n", CDEBUG(D_DENTRY, "ldd on dentry %pd (%p) parent %p inode %p refc %d\n",
de, de, de->d_parent, d_inode(de), de, de, de->d_parent, d_inode(de), d_count(de));
d_count(de));
if (!de->d_fsdata) { if (!de->d_fsdata) {
struct ll_dentry_data *lld; struct ll_dentry_data *lld;
......
...@@ -368,7 +368,7 @@ struct page *ll_get_dir_page(struct inode *dir, __u64 hash, ...@@ -368,7 +368,7 @@ struct page *ll_get_dir_page(struct inode *dir, __u64 hash,
if (request) if (request)
ptlrpc_req_finished(request); ptlrpc_req_finished(request);
if (rc < 0) { if (rc < 0) {
CERROR("lock enqueue: "DFID" at %llu: rc %d\n", CERROR("lock enqueue: " DFID " at %llu: rc %d\n",
PFID(ll_inode2fid(dir)), hash, rc); PFID(ll_inode2fid(dir)), hash, rc);
return ERR_PTR(rc); return ERR_PTR(rc);
} }
......
...@@ -287,7 +287,8 @@ static int ll_md_close(struct obd_export *md_exp, struct inode *inode, ...@@ -287,7 +287,8 @@ static int ll_md_close(struct obd_export *md_exp, struct inode *inode,
* application crashed, we need to release here. * application crashed, we need to release here.
*/ */
rc = ll_lease_close(fd->fd_lease_och, inode, &lease_broken); rc = ll_lease_close(fd->fd_lease_och, inode, &lease_broken);
CDEBUG(rc ? D_ERROR : D_INODE, "Clean up lease "DFID" %d/%d\n", CDEBUG(rc ? D_ERROR : D_INODE,
"Clean up lease " DFID " %d/%d\n",
PFID(&lli->lli_fid), rc, lease_broken); PFID(&lli->lli_fid), rc, lease_broken);
fd->fd_lease_och = NULL; fd->fd_lease_och = NULL;
...@@ -727,7 +728,8 @@ int ll_file_open(struct inode *inode, struct file *file) ...@@ -727,7 +728,8 @@ int ll_file_open(struct inode *inode, struct file *file)
} }
static int ll_md_blocking_lease_ast(struct ldlm_lock *lock, static int ll_md_blocking_lease_ast(struct ldlm_lock *lock,
struct ldlm_lock_desc *desc, void *data, int flag) struct ldlm_lock_desc *desc,
void *data, int flag)
{ {
int rc; int rc;
struct lustre_handle lockh; struct lustre_handle lockh;
...@@ -909,7 +911,7 @@ static int ll_lease_close(struct obd_client_handle *och, struct inode *inode, ...@@ -909,7 +911,7 @@ static int ll_lease_close(struct obd_client_handle *och, struct inode *inode,
ldlm_lock_put(lock); ldlm_lock_put(lock);
} }
CDEBUG(D_INODE, "lease for "DFID" broken? %d\n", CDEBUG(D_INODE, "lease for " DFID " broken? %d\n",
PFID(&ll_i2info(inode)->lli_fid), cancelled); PFID(&ll_i2info(inode)->lli_fid), cancelled);
if (!cancelled) if (!cancelled)
...@@ -1026,7 +1028,7 @@ int ll_merge_lvb(const struct lu_env *env, struct inode *inode) ...@@ -1026,7 +1028,7 @@ int ll_merge_lvb(const struct lu_env *env, struct inode *inode)
if (lvb.lvb_mtime < attr->cat_mtime) if (lvb.lvb_mtime < attr->cat_mtime)
lvb.lvb_mtime = attr->cat_mtime; lvb.lvb_mtime = attr->cat_mtime;
CDEBUG(D_VFSTRACE, DFID" updating i_size %llu\n", CDEBUG(D_VFSTRACE, DFID " updating i_size %llu\n",
PFID(&lli->lli_fid), attr->cat_size); PFID(&lli->lli_fid), attr->cat_size);
cl_isize_write_nolock(inode, attr->cat_size); cl_isize_write_nolock(inode, attr->cat_size);
...@@ -3455,7 +3457,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode, ...@@ -3455,7 +3457,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode,
*gen = md.lsm->lsm_layout_gen; *gen = md.lsm->lsm_layout_gen;
rc = 0; rc = 0;
} else { } else {
CERROR("%s: file "DFID" unpackmd error: %d\n", CERROR("%s: file " DFID " unpackmd error: %d\n",
ll_get_fsname(inode->i_sb, NULL, 0), ll_get_fsname(inode->i_sb, NULL, 0),
PFID(&lli->lli_fid), rc); PFID(&lli->lli_fid), rc);
} }
...@@ -3485,7 +3487,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode, ...@@ -3485,7 +3487,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode,
/* wait for IO to complete if it's still being used. */ /* wait for IO to complete if it's still being used. */
if (wait_layout) { if (wait_layout) {
CDEBUG(D_INODE, "%s: %p/"DFID" wait for layout reconf.\n", CDEBUG(D_INODE, "%s: %p/" DFID " wait for layout reconf.\n",
ll_get_fsname(inode->i_sb, NULL, 0), ll_get_fsname(inode->i_sb, NULL, 0),
inode, PFID(&lli->lli_fid)); inode, PFID(&lli->lli_fid));
...@@ -3496,7 +3498,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode, ...@@ -3496,7 +3498,7 @@ static int ll_layout_lock_set(struct lustre_handle *lockh, enum ldlm_mode mode,
if (rc == 0) if (rc == 0)
rc = -EAGAIN; rc = -EAGAIN;
CDEBUG(D_INODE, "file: "DFID" waiting layout return: %d.\n", CDEBUG(D_INODE, "file: " DFID " waiting layout return: %d.\n",
PFID(&lli->lli_fid), rc); PFID(&lli->lli_fid), rc);
} }
return rc; return rc;
...@@ -3569,7 +3571,7 @@ int ll_layout_refresh(struct inode *inode, __u32 *gen) ...@@ -3569,7 +3571,7 @@ int ll_layout_refresh(struct inode *inode, __u32 *gen)
it.it_op = IT_LAYOUT; it.it_op = IT_LAYOUT;
lockh.cookie = 0ULL; lockh.cookie = 0ULL;
LDLM_DEBUG_NOLOCK("%s: requeue layout lock for file %p/"DFID".\n", LDLM_DEBUG_NOLOCK("%s: requeue layout lock for file %p/" DFID ".\n",
ll_get_fsname(inode->i_sb, NULL, 0), inode, ll_get_fsname(inode->i_sb, NULL, 0), inode,
PFID(&lli->lli_fid)); PFID(&lli->lli_fid));
......
...@@ -53,8 +53,7 @@ void vvp_write_pending(struct ccc_object *club, struct ccc_page *page) ...@@ -53,8 +53,7 @@ void vvp_write_pending(struct ccc_object *club, struct ccc_page *page)
spin_lock(&lli->lli_lock); spin_lock(&lli->lli_lock);
lli->lli_flags |= LLIF_SOM_DIRTY; lli->lli_flags |= LLIF_SOM_DIRTY;
if (page && list_empty(&page->cpg_pending_linkage)) if (page && list_empty(&page->cpg_pending_linkage))
list_add(&page->cpg_pending_linkage, list_add(&page->cpg_pending_linkage, &club->cob_pending_list);
&club->cob_pending_list);
spin_unlock(&lli->lli_lock); spin_unlock(&lli->lli_lock);
} }
......
...@@ -287,11 +287,8 @@ static inline void ll_layout_version_set(struct ll_inode_info *lli, __u32 gen) ...@@ -287,11 +287,8 @@ static inline void ll_layout_version_set(struct ll_inode_info *lli, __u32 gen)
int ll_xattr_cache_destroy(struct inode *inode); int ll_xattr_cache_destroy(struct inode *inode);
int ll_xattr_cache_get(struct inode *inode, int ll_xattr_cache_get(struct inode *inode, const char *name,
const char *name, char *buffer, size_t size, __u64 valid);
char *buffer,
size_t size,
__u64 valid);
/* /*
* Locking to guarantee consistency of non-atomic updates to long long i_size, * Locking to guarantee consistency of non-atomic updates to long long i_size,
...@@ -970,8 +967,8 @@ int ll_close_thread_start(struct ll_close_queue **lcq_ret); ...@@ -970,8 +967,8 @@ int ll_close_thread_start(struct ll_close_queue **lcq_ret);
int ll_teardown_mmaps(struct address_space *mapping, __u64 first, __u64 last); int ll_teardown_mmaps(struct address_space *mapping, __u64 first, __u64 last);
int ll_file_mmap(struct file *file, struct vm_area_struct *vma); int ll_file_mmap(struct file *file, struct vm_area_struct *vma);
void policy_from_vma(ldlm_policy_data_t *policy, void policy_from_vma(ldlm_policy_data_t *policy, struct vm_area_struct *vma,
struct vm_area_struct *vma, unsigned long addr, size_t count); unsigned long addr, size_t count);
struct vm_area_struct *our_vma(struct mm_struct *mm, unsigned long addr, struct vm_area_struct *our_vma(struct mm_struct *mm, unsigned long addr,
size_t count); size_t count);
......
...@@ -1215,7 +1215,7 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr, bool hsm_import) ...@@ -1215,7 +1215,7 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr, bool hsm_import)
int rc = 0, rc1 = 0; int rc = 0, rc1 = 0;
CDEBUG(D_VFSTRACE, CDEBUG(D_VFSTRACE,
"%s: setattr inode %p/fid:"DFID "%s: setattr inode %p/fid:" DFID
" from %llu to %llu, valid %x, hsm_import %d\n", " from %llu to %llu, valid %x, hsm_import %d\n",
ll_get_fsname(inode->i_sb, NULL, 0), inode, ll_get_fsname(inode->i_sb, NULL, 0), inode,
PFID(&lli->lli_fid), i_size_read(inode), attr->ia_size, PFID(&lli->lli_fid), i_size_read(inode), attr->ia_size,
......
...@@ -191,7 +191,7 @@ static int ll_encode_fh(struct inode *inode, __u32 *fh, int *plen, ...@@ -191,7 +191,7 @@ static int ll_encode_fh(struct inode *inode, __u32 *fh, int *plen,
int fileid_len = sizeof(struct lustre_nfs_fid) / 4; int fileid_len = sizeof(struct lustre_nfs_fid) / 4;
struct lustre_nfs_fid *nfs_fid = (void *)fh; struct lustre_nfs_fid *nfs_fid = (void *)fh;
CDEBUG(D_INFO, "encoding for (%lu,"DFID") maxlen=%d minlen=%d\n", CDEBUG(D_INFO, "encoding for (%lu," DFID ") maxlen=%d minlen=%d\n",
inode->i_ino, PFID(ll_inode2fid(inode)), *plen, fileid_len); inode->i_ino, PFID(ll_inode2fid(inode)), *plen, fileid_len);
if (*plen < fileid_len) { if (*plen < fileid_len) {
...@@ -298,7 +298,7 @@ static struct dentry *ll_get_parent(struct dentry *dchild) ...@@ -298,7 +298,7 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
sbi = ll_s2sbi(dir->i_sb); sbi = ll_s2sbi(dir->i_sb);
CDEBUG(D_INFO, "getting parent for (%lu,"DFID")\n", CDEBUG(D_INFO, "getting parent for (%lu," DFID ")\n",
dir->i_ino, PFID(ll_inode2fid(dir))); dir->i_ino, PFID(ll_inode2fid(dir)));
rc = ll_get_default_mdsize(sbi, &lmmsize); rc = ll_get_default_mdsize(sbi, &lmmsize);
...@@ -320,7 +320,7 @@ static struct dentry *ll_get_parent(struct dentry *dchild) ...@@ -320,7 +320,7 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
body = req_capsule_server_get(&req->rq_pill, &RMF_MDT_BODY); body = req_capsule_server_get(&req->rq_pill, &RMF_MDT_BODY);
LASSERT(body->valid & OBD_MD_FLID); LASSERT(body->valid & OBD_MD_FLID);
CDEBUG(D_INFO, "parent for "DFID" is "DFID"\n", CDEBUG(D_INFO, "parent for " DFID " is " DFID "\n",
PFID(ll_inode2fid(dir)), PFID(&body->fid1)); PFID(ll_inode2fid(dir)), PFID(&body->fid1));
result = ll_iget_for_nfs(dir->i_sb, &body->fid1, NULL); result = ll_iget_for_nfs(dir->i_sb, &body->fid1, NULL);
......
...@@ -120,7 +120,7 @@ struct inode *ll_iget(struct super_block *sb, ino_t hash, ...@@ -120,7 +120,7 @@ struct inode *ll_iget(struct super_block *sb, ino_t hash,
if (S_ISREG(inode->i_mode) && if (S_ISREG(inode->i_mode) &&
!ll_i2info(inode)->lli_clob) { !ll_i2info(inode)->lli_clob) {
CDEBUG(D_INODE, CDEBUG(D_INODE,
"%s: apply lsm %p to inode "DFID".\n", "%s: apply lsm %p to inode " DFID ".\n",
ll_get_fsname(sb, NULL, 0), md->lsm, ll_get_fsname(sb, NULL, 0), md->lsm,
PFID(ll_inode2fid(inode))); PFID(ll_inode2fid(inode)));
rc = cl_file_inode_init(inode, md); rc = cl_file_inode_init(inode, md);
......
...@@ -626,8 +626,8 @@ static int ll_read_ahead_pages(const struct lu_env *env, ...@@ -626,8 +626,8 @@ static int ll_read_ahead_pages(const struct lu_env *env,
RIA_DEBUG(ria); RIA_DEBUG(ria);
stride_ria = ria->ria_length > ria->ria_pages && ria->ria_pages > 0; stride_ria = ria->ria_length > ria->ria_pages && ria->ria_pages > 0;
for (page_idx = ria->ria_start; page_idx <= ria->ria_end && for (page_idx = ria->ria_start;
*reserved_pages > 0; page_idx++) { page_idx <= ria->ria_end && *reserved_pages > 0; page_idx++) {
if (ras_inside_ra_window(page_idx, ria)) { if (ras_inside_ra_window(page_idx, ria)) {
/* If the page is inside the read-ahead window*/ /* If the page is inside the read-ahead window*/
rc = ll_read_ahead_page(env, io, queue, rc = ll_read_ahead_page(env, io, queue,
......
...@@ -514,8 +514,8 @@ static void ll_sai_put(struct ll_statahead_info *sai) ...@@ -514,8 +514,8 @@ static void ll_sai_put(struct ll_statahead_info *sai)
PFID(&lli->lli_fid), PFID(&lli->lli_fid),
sai->sai_sent, sai->sai_replied); sai->sai_sent, sai->sai_replied);
list_for_each_entry_safe(entry, next, list_for_each_entry_safe(entry, next, &sai->sai_entries,
&sai->sai_entries, se_link) se_link)
do_sa_entry_fini(sai, entry); do_sa_entry_fini(sai, entry);
LASSERT(list_empty(&sai->sai_entries)); LASSERT(list_empty(&sai->sai_entries));
...@@ -1013,8 +1013,8 @@ static void ll_start_agl(struct dentry *parent, struct ll_statahead_info *sai) ...@@ -1013,8 +1013,8 @@ static void ll_start_agl(struct dentry *parent, struct ll_statahead_info *sai)
sai, parent); sai, parent);
plli = ll_i2info(d_inode(parent)); plli = ll_i2info(d_inode(parent));
task = kthread_run(ll_agl_thread, parent, task = kthread_run(ll_agl_thread, parent, "ll_agl_%u",
"ll_agl_%u", plli->lli_opendir_pid); plli->lli_opendir_pid);
if (IS_ERR(task)) { if (IS_ERR(task)) {
CERROR("can't start ll_agl thread, rc: %ld\n", PTR_ERR(task)); CERROR("can't start ll_agl thread, rc: %ld\n", PTR_ERR(task));
thread_set_flags(thread, SVC_STOPPED); thread_set_flags(thread, SVC_STOPPED);
......
...@@ -44,13 +44,12 @@ ...@@ -44,13 +44,12 @@
#include "../include/cl_object.h" #include "../include/cl_object.h"
#include "llite_internal.h" #include "llite_internal.h"
int vvp_io_init (const struct lu_env *env, int vvp_io_init(const struct lu_env *env,
struct cl_object *obj, struct cl_io *io); struct cl_object *obj, struct cl_io *io);
int vvp_lock_init (const struct lu_env *env, int vvp_lock_init(const struct lu_env *env,
struct cl_object *obj, struct cl_lock *lock, struct cl_object *obj, struct cl_lock *lock,
const struct cl_io *io); const struct cl_io *io);
int vvp_page_init (const struct lu_env *env, int vvp_page_init(const struct lu_env *env, struct cl_object *obj,
struct cl_object *obj,
struct cl_page *page, struct page *vmpage); struct cl_page *page, struct page *vmpage);
struct lu_object *vvp_object_alloc(const struct lu_env *env, struct lu_object *vvp_object_alloc(const struct lu_env *env,
const struct lu_object_header *hdr, const struct lu_object_header *hdr,
......
...@@ -359,8 +359,7 @@ static int vvp_page_make_ready(const struct lu_env *env, ...@@ -359,8 +359,7 @@ static int vvp_page_make_ready(const struct lu_env *env,
LASSERT(pg->cp_state == CPS_CACHED); LASSERT(pg->cp_state == CPS_CACHED);
/* This actually clears the dirty bit in the radix tree. */ /* This actually clears the dirty bit in the radix tree. */
set_page_writeback(vmpage); set_page_writeback(vmpage);
vvp_write_pending(cl2ccc(slice->cpl_obj), vvp_write_pending(cl2ccc(slice->cpl_obj), cl2ccc_page(slice));
cl2ccc_page(slice));
CL_PAGE_HEADER(D_PAGE, env, pg, "readied\n"); CL_PAGE_HEADER(D_PAGE, env, pg, "readied\n");
} else if (pg->cp_state == CPS_PAGEOUT) { } else if (pg->cp_state == CPS_PAGEOUT) {
/* is it possible for osc_flush_async_page() to already /* is it possible for osc_flush_async_page() to already
...@@ -544,8 +543,7 @@ int vvp_page_init(const struct lu_env *env, struct cl_object *obj, ...@@ -544,8 +543,7 @@ int vvp_page_init(const struct lu_env *env, struct cl_object *obj,
if (page->cp_type == CPT_CACHEABLE) { if (page->cp_type == CPT_CACHEABLE) {
SetPagePrivate(vmpage); SetPagePrivate(vmpage);
vmpage->private = (unsigned long)page; vmpage->private = (unsigned long)page;
cl_page_slice_add(page, &cpg->cpg_cl, obj, cl_page_slice_add(page, &cpg->cpg_cl, obj, &vvp_page_ops);
&vvp_page_ops);
} else { } else {
struct ccc_object *clobj = cl2ccc(obj); struct ccc_object *clobj = cl2ccc(obj);
......
...@@ -133,8 +133,8 @@ static int ll_xattr_cache_add(struct list_head *cache, ...@@ -133,8 +133,8 @@ static int ll_xattr_cache_add(struct list_head *cache,
xattr->xe_vallen = xattr_val_len; xattr->xe_vallen = xattr_val_len;
list_add(&xattr->xe_list, cache); list_add(&xattr->xe_list, cache);
CDEBUG(D_CACHE, "set: [%s]=%.*s\n", xattr_name, CDEBUG(D_CACHE, "set: [%s]=%.*s\n", xattr_name, xattr_val_len,
xattr_val_len, xattr_val); xattr_val);
return 0; return 0;
err_value: err_value:
...@@ -469,11 +469,8 @@ static int ll_xattr_cache_refill(struct inode *inode, struct lookup_intent *oit) ...@@ -469,11 +469,8 @@ static int ll_xattr_cache_refill(struct inode *inode, struct lookup_intent *oit)
* \retval -ERANGE the buffer is not large enough * \retval -ERANGE the buffer is not large enough
* \retval -ENODATA no such attr or the list is empty * \retval -ENODATA no such attr or the list is empty
*/ */
int ll_xattr_cache_get(struct inode *inode, int ll_xattr_cache_get(struct inode *inode, const char *name, char *buffer,
const char *name, size_t size, __u64 valid)
char *buffer,
size_t size,
__u64 valid)
{ {
struct lookup_intent oit = { .it_op = IT_GETXATTR }; struct lookup_intent oit = { .it_op = IT_GETXATTR };
struct ll_inode_info *lli = ll_i2info(inode); struct ll_inode_info *lli = ll_i2info(inode);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment