Commit e1bdf024 authored by Daniel Scheller's avatar Daniel Scheller Committed by Mauro Carvalho Chehab

media: dvb-frontends/lnbh25: improve kernellog output

Use dev_dbg() in conjunction with the %*ph format macro to print the vmon
status debug, thus hiding continuous hexdumping from default log levels.
Also, change the attach success log line from error to info severity.
Signed-off-by: default avatarDaniel Scheller <d.scheller@gmx.net>
Acked-by: default avatarAbylay Ospan <aospan@netup.ru>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent bd7a85d3
...@@ -76,8 +76,8 @@ static int lnbh25_read_vmon(struct lnbh25_priv *priv) ...@@ -76,8 +76,8 @@ static int lnbh25_read_vmon(struct lnbh25_priv *priv)
return ret; return ret;
} }
} }
print_hex_dump_bytes("lnbh25_read_vmon: ", dev_dbg(&priv->i2c->dev, "%s(): %*ph\n",
DUMP_PREFIX_OFFSET, status, sizeof(status)); __func__, (int) sizeof(status), status);
if ((status[0] & (LNBH25_STATUS_OFL | LNBH25_STATUS_VMON)) != 0) { if ((status[0] & (LNBH25_STATUS_OFL | LNBH25_STATUS_VMON)) != 0) {
dev_err(&priv->i2c->dev, dev_err(&priv->i2c->dev,
"%s(): voltage in failure state, status reg 0x%x\n", "%s(): voltage in failure state, status reg 0x%x\n",
...@@ -178,7 +178,7 @@ struct dvb_frontend *lnbh25_attach(struct dvb_frontend *fe, ...@@ -178,7 +178,7 @@ struct dvb_frontend *lnbh25_attach(struct dvb_frontend *fe,
fe->ops.release_sec = lnbh25_release; fe->ops.release_sec = lnbh25_release;
fe->ops.set_voltage = lnbh25_set_voltage; fe->ops.set_voltage = lnbh25_set_voltage;
dev_err(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n", dev_info(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n",
__func__, priv->i2c_address); __func__, priv->i2c_address);
return fe; return fe;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment