Commit e219e662 authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by Luis Henriques

rtnetlink: release net refcnt on error in do_setlink()

commit e0ebde0e upstream.

rtnl_link_get_net() holds a reference on the 'struct net', we need to release
it in case of error.

CC: Eric W. Biederman <ebiederm@xmission.com>
Fixes: b51642f6 ("net: Enable a userns root rtnl calls that are safe for unprivilged users")
Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent d5197164
...@@ -1490,6 +1490,7 @@ static int do_setlink(const struct sk_buff *skb, ...@@ -1490,6 +1490,7 @@ static int do_setlink(const struct sk_buff *skb,
goto errout; goto errout;
} }
if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) { if (!netlink_ns_capable(skb, net->user_ns, CAP_NET_ADMIN)) {
put_net(net);
err = -EPERM; err = -EPERM;
goto errout; goto errout;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment