Commit e2276c7e authored by Dan Carpenter's avatar Dan Carpenter Committed by Sasha Levin

memstick: mspro_block: add missing curly braces

[ Upstream commit 13f6b191 ]

Using the indenting we can see the curly braces were obviously intended.
This is a static checker fix, but my guess is that we don't read enough
bytes, because we don't calculate "t_len" correctly.

Fixes: f1d82698 ('memstick: use fully asynchronous request processing')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Alex Dubov <oakad@yahoo.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent e0407f4a
...@@ -758,7 +758,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error) ...@@ -758,7 +758,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) { if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) {
if (msb->data_dir == READ) { if (msb->data_dir == READ) {
for (cnt = 0; cnt < msb->current_seg; cnt++) for (cnt = 0; cnt < msb->current_seg; cnt++) {
t_len += msb->req_sg[cnt].length t_len += msb->req_sg[cnt].length
/ msb->page_size; / msb->page_size;
...@@ -766,6 +766,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error) ...@@ -766,6 +766,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
t_len += msb->current_page - 1; t_len += msb->current_page - 1;
t_len *= msb->page_size; t_len *= msb->page_size;
}
} }
} else } else
t_len = blk_rq_bytes(msb->block_req); t_len = blk_rq_bytes(msb->block_req);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment