Commit e2c8e92d authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba

btrfs: fix wrong file range cleanup after an error filling dealloc range

If an error happens while running dellaloc in COW mode for a range, we can
end up calling extent_clear_unlock_delalloc() for a range that goes beyond
our range's end offset by 1 byte, which affects 1 extra page. This results
in clearing bits and doing page operations (such as a page unlock) outside
our target range.

Fix that by calling extent_clear_unlock_delalloc() with an inclusive end
offset, instead of an exclusive end offset, at cow_file_range().

Fixes: a315e68f ("Btrfs: fix invalid attempt to free reserved space on failure to cow range")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 213ff4b7
...@@ -1141,7 +1141,7 @@ static noinline int cow_file_range(struct inode *inode, ...@@ -1141,7 +1141,7 @@ static noinline int cow_file_range(struct inode *inode,
*/ */
if (extent_reserved) { if (extent_reserved) {
extent_clear_unlock_delalloc(inode, start, extent_clear_unlock_delalloc(inode, start,
start + cur_alloc_size, start + cur_alloc_size - 1,
locked_page, locked_page,
clear_bits, clear_bits,
page_ops); page_ops);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment