Commit e315e7b8 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Paolo Abeni

net: libwx: fix memory leak in wx_setup_rx_resources

When wx_alloc_page_pool() failed in wx_setup_rx_resources(), it doesn't
release DMA buffer. Add dma_free_coherent() in the error path to release
the DMA buffer.

Fixes: 850b9711 ("net: libwx: Allocate Rx and Tx resources")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230418065450.2268522-1-shaozhengchao@huawei.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a5962e0a
...@@ -1798,10 +1798,13 @@ static int wx_setup_rx_resources(struct wx_ring *rx_ring) ...@@ -1798,10 +1798,13 @@ static int wx_setup_rx_resources(struct wx_ring *rx_ring)
ret = wx_alloc_page_pool(rx_ring); ret = wx_alloc_page_pool(rx_ring);
if (ret < 0) { if (ret < 0) {
dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret); dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret);
goto err; goto err_desc;
} }
return 0; return 0;
err_desc:
dma_free_coherent(dev, rx_ring->size, rx_ring->desc, rx_ring->dma);
err: err:
kvfree(rx_ring->rx_buffer_info); kvfree(rx_ring->rx_buffer_info);
rx_ring->rx_buffer_info = NULL; rx_ring->rx_buffer_info = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment