Commit e3cccff9 authored by Philipp Zabel's avatar Philipp Zabel Committed by Mauro Carvalho Chehab

[media] coda: don't ever use subsampling ping-pong buffers as reconstructed reference buffers

On i.MX6, two subsampling ping-pong buffers are used for motion estimation and
deblocking They should not be counted as framebuffers, or they will be also used
to store reconstructed frames, causing visible artifacts in P-frames.
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent f4706d6e
...@@ -718,6 +718,7 @@ static int coda_start_encoding(struct coda_ctx *ctx) ...@@ -718,6 +718,7 @@ static int coda_start_encoding(struct coda_ctx *ctx)
struct vb2_buffer *buf; struct vb2_buffer *buf;
int gamma, ret, value; int gamma, ret, value;
u32 dst_fourcc; u32 dst_fourcc;
int num_fb;
u32 stride; u32 stride;
q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
...@@ -983,12 +984,14 @@ static int coda_start_encoding(struct coda_ctx *ctx) ...@@ -983,12 +984,14 @@ static int coda_start_encoding(struct coda_ctx *ctx)
v4l2_err(v4l2_dev, "failed to allocate framebuffers\n"); v4l2_err(v4l2_dev, "failed to allocate framebuffers\n");
goto out; goto out;
} }
num_fb = 2;
stride = q_data_src->bytesperline; stride = q_data_src->bytesperline;
} else { } else {
ctx->num_internal_frames = 0; ctx->num_internal_frames = 0;
num_fb = 0;
stride = 0; stride = 0;
} }
coda_write(dev, ctx->num_internal_frames, CODA_CMD_SET_FRAME_BUF_NUM); coda_write(dev, num_fb, CODA_CMD_SET_FRAME_BUF_NUM);
coda_write(dev, stride, CODA_CMD_SET_FRAME_BUF_STRIDE); coda_write(dev, stride, CODA_CMD_SET_FRAME_BUF_STRIDE);
if (dev->devtype->product == CODA_7541) { if (dev->devtype->product == CODA_7541) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment