Commit e515c18b authored by Lukas Czerner's avatar Lukas Czerner Committed by Chris Mason

btrfs: Return EINVAL when length to trim is less than FSB

Currently if len argument in btrfs_ioctl_fitrim() is smaller than
one FSB we will continue and finally return 0 bytes discarded.
However if the length to discard is smaller then file system block
we should really return EINVAL.
Signed-off-by: default avatarLukas Czerner <lczerner@redhat.com>
parent 5b7ff5b3
...@@ -343,7 +343,8 @@ static noinline int btrfs_ioctl_fitrim(struct file *file, void __user *arg) ...@@ -343,7 +343,8 @@ static noinline int btrfs_ioctl_fitrim(struct file *file, void __user *arg)
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (copy_from_user(&range, arg, sizeof(range))) if (copy_from_user(&range, arg, sizeof(range)))
return -EFAULT; return -EFAULT;
if (range.start > total_bytes) if (range.start > total_bytes ||
range.len < fs_info->sb->s_blocksize)
return -EINVAL; return -EINVAL;
range.len = min(range.len, total_bytes - range.start); range.len = min(range.len, total_bytes - range.start);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment