Commit e53c7413 authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu

crypto: qat - prevent underflow in rp2srv_store()

The "ring" variable has an upper bounds check but nothing checks for
negatives.  This code uses kstrtouint() already and it was obviously
intended to be declared as unsigned int.  Make it so.

Fixes: dbc8876d ("crypto: qat - add rp2svc sysfs attribute")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent bc197f57
...@@ -242,7 +242,8 @@ static ssize_t rp2srv_store(struct device *dev, struct device_attribute *attr, ...@@ -242,7 +242,8 @@ static ssize_t rp2srv_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
struct adf_accel_dev *accel_dev; struct adf_accel_dev *accel_dev;
int ring, num_rings, ret; int num_rings, ret;
unsigned int ring;
accel_dev = adf_devmgr_pci_to_accel_dev(to_pci_dev(dev)); accel_dev = adf_devmgr_pci_to_accel_dev(to_pci_dev(dev));
if (!accel_dev) if (!accel_dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment