Commit e5b2e3e7 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Wolfram Sang

i2c: sh7760: add IRQ check

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with invalid
IRQ #s.

Fixes: a26c20b1 ("i2c: Renesas SH7760 I2C master driver")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 147178cf
...@@ -471,7 +471,10 @@ static int sh7760_i2c_probe(struct platform_device *pdev) ...@@ -471,7 +471,10 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
goto out2; goto out2;
} }
id->irq = platform_get_irq(pdev, 0); ret = platform_get_irq(pdev, 0);
if (ret < 0)
return ret;
id->irq = ret;
id->adap.nr = pdev->id; id->adap.nr = pdev->id;
id->adap.algo = &sh7760_i2c_algo; id->adap.algo = &sh7760_i2c_algo;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment