Commit e607ff63 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Thomas Bogendoerfer

MIPS: generic: Update node names to avoid unit addresses

With the latest mkimage from U-Boot 2021.04, the generic defconfigs no
longer build, failing with:

/usr/bin/mkimage: verify_header failed for FIT Image support with exit code 1

This is expected after the linked U-Boot commits because '@' is
forbidden in the node names due to the way that libfdt treats nodes with
the same prefix but different unit addresses.

Switch the '@' in the node name to '-'. Drop the unit addresses from the
hash and kernel child nodes because there is only one node so they do
not need to have a number to differentiate them.

Cc: stable@vger.kernel.org
Link: https://source.denx.de/u-boot/u-boot/-/commit/79af75f7776fc20b0d7eb6afe1e27c00fdb4b9b4
Link: https://source.denx.de/u-boot/u-boot/-/commit/3f04db891a353f4b127ed57279279f851c6b4917Suggested-by: default avatarSimon Glass <sjg@chromium.org>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarTom Rini <trini@konsulko.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent ddb002d6
/ { / {
images { images {
fdt@boston { fdt-boston {
description = "img,boston Device Tree"; description = "img,boston Device Tree";
data = /incbin/("boot/dts/img/boston.dtb"); data = /incbin/("boot/dts/img/boston.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
}; };
configurations { configurations {
conf@boston { conf-boston {
description = "Boston Linux kernel"; description = "Boston Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@boston"; fdt = "fdt-boston";
}; };
}; };
}; };
/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ /* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
/ { / {
images { images {
fdt@jaguar2_pcb110 { fdt-jaguar2_pcb110 {
description = "MSCC Jaguar2 PCB110 Device Tree"; description = "MSCC Jaguar2 PCB110 Device Tree";
data = /incbin/("boot/dts/mscc/jaguar2_pcb110.dtb"); data = /incbin/("boot/dts/mscc/jaguar2_pcb110.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
fdt@jaguar2_pcb111 { fdt-jaguar2_pcb111 {
description = "MSCC Jaguar2 PCB111 Device Tree"; description = "MSCC Jaguar2 PCB111 Device Tree";
data = /incbin/("boot/dts/mscc/jaguar2_pcb111.dtb"); data = /incbin/("boot/dts/mscc/jaguar2_pcb111.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
...@@ -26,14 +26,14 @@ ...@@ -26,14 +26,14 @@
configurations { configurations {
pcb110 { pcb110 {
description = "Jaguar2 Linux kernel"; description = "Jaguar2 Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@jaguar2_pcb110"; fdt = "fdt-jaguar2_pcb110";
ramdisk = "ramdisk"; ramdisk = "ramdisk";
}; };
pcb111 { pcb111 {
description = "Jaguar2 Linux kernel"; description = "Jaguar2 Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@jaguar2_pcb111"; fdt = "fdt-jaguar2_pcb111";
ramdisk = "ramdisk"; ramdisk = "ramdisk";
}; };
}; };
......
/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ /* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
/ { / {
images { images {
fdt@luton_pcb091 { fdt-luton_pcb091 {
description = "MSCC Luton PCB091 Device Tree"; description = "MSCC Luton PCB091 Device Tree";
data = /incbin/("boot/dts/mscc/luton_pcb091.dtb"); data = /incbin/("boot/dts/mscc/luton_pcb091.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
configurations { configurations {
pcb091 { pcb091 {
description = "Luton Linux kernel"; description = "Luton Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@luton_pcb091"; fdt = "fdt-luton_pcb091";
}; };
}; };
}; };
/ { / {
images { images {
fdt@ni169445 { fdt-ni169445 {
description = "NI 169445 device tree"; description = "NI 169445 device tree";
data = /incbin/("boot/dts/ni/169445.dtb"); data = /incbin/("boot/dts/ni/169445.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
}; };
configurations { configurations {
conf@ni169445 { conf-ni169445 {
description = "NI 169445 Linux Kernel"; description = "NI 169445 Linux Kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@ni169445"; fdt = "fdt-ni169445";
}; };
}; };
}; };
/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ /* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
/ { / {
images { images {
fdt@ocelot_pcb123 { fdt-ocelot_pcb123 {
description = "MSCC Ocelot PCB123 Device Tree"; description = "MSCC Ocelot PCB123 Device Tree";
data = /incbin/("boot/dts/mscc/ocelot_pcb123.dtb"); data = /incbin/("boot/dts/mscc/ocelot_pcb123.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
fdt@ocelot_pcb120 { fdt-ocelot_pcb120 {
description = "MSCC Ocelot PCB120 Device Tree"; description = "MSCC Ocelot PCB120 Device Tree";
data = /incbin/("boot/dts/mscc/ocelot_pcb120.dtb"); data = /incbin/("boot/dts/mscc/ocelot_pcb120.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
}; };
configurations { configurations {
conf@ocelot_pcb123 { conf-ocelot_pcb123 {
description = "Ocelot Linux kernel"; description = "Ocelot Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@ocelot_pcb123"; fdt = "fdt-ocelot_pcb123";
}; };
conf@ocelot_pcb120 { conf-ocelot_pcb120 {
description = "Ocelot Linux kernel"; description = "Ocelot Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@ocelot_pcb120"; fdt = "fdt-ocelot_pcb120";
}; };
}; };
}; };
/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ /* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
/ { / {
images { images {
fdt@serval_pcb105 { fdt-serval_pcb105 {
description = "MSCC Serval PCB105 Device Tree"; description = "MSCC Serval PCB105 Device Tree";
data = /incbin/("boot/dts/mscc/serval_pcb105.dtb"); data = /incbin/("boot/dts/mscc/serval_pcb105.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
configurations { configurations {
pcb105 { pcb105 {
description = "Serval Linux kernel"; description = "Serval Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@serval_pcb105"; fdt = "fdt-serval_pcb105";
ramdisk = "ramdisk"; ramdisk = "ramdisk";
}; };
}; };
......
/ { / {
images { images {
fdt@xilfpga { fdt-xilfpga {
description = "MIPSfpga (xilfpga) Device Tree"; description = "MIPSfpga (xilfpga) Device Tree";
data = /incbin/("boot/dts/xilfpga/nexys4ddr.dtb"); data = /incbin/("boot/dts/xilfpga/nexys4ddr.dtb");
type = "flat_dt"; type = "flat_dt";
arch = "mips"; arch = "mips";
compression = "none"; compression = "none";
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
}; };
configurations { configurations {
conf@xilfpga { conf-xilfpga {
description = "MIPSfpga Linux kernel"; description = "MIPSfpga Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
fdt = "fdt@xilfpga"; fdt = "fdt-xilfpga";
}; };
}; };
}; };
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#address-cells = <ADDR_CELLS>; #address-cells = <ADDR_CELLS>;
images { images {
kernel@0 { kernel {
description = KERNEL_NAME; description = KERNEL_NAME;
data = /incbin/(VMLINUX_BINARY); data = /incbin/(VMLINUX_BINARY);
type = "kernel"; type = "kernel";
...@@ -15,18 +15,18 @@ ...@@ -15,18 +15,18 @@
compression = VMLINUX_COMPRESSION; compression = VMLINUX_COMPRESSION;
load = /bits/ ADDR_BITS <VMLINUX_LOAD_ADDRESS>; load = /bits/ ADDR_BITS <VMLINUX_LOAD_ADDRESS>;
entry = /bits/ ADDR_BITS <VMLINUX_ENTRY_ADDRESS>; entry = /bits/ ADDR_BITS <VMLINUX_ENTRY_ADDRESS>;
hash@0 { hash {
algo = "sha1"; algo = "sha1";
}; };
}; };
}; };
configurations { configurations {
default = "conf@default"; default = "conf-default";
conf@default { conf-default {
description = "Generic Linux kernel"; description = "Generic Linux kernel";
kernel = "kernel@0"; kernel = "kernel";
}; };
}; };
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment