Commit e6478de4 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Greg Kroah-Hartman

vfs: Remove incorrect debugging WARN in prepend_path

commit 93e3bce6 upstream.

The warning message in prepend_path is unclear and outdated.  It was
added as a warning that the mechanism for generating names of pseudo
files had been removed from prepend_path and d_dname should be used
instead.  Unfortunately the warning reads like a general warning,
making it unclear what to do with it.

Remove the warning.  The transition it was added to warn about is long
over, and I added code several years ago which in rare cases causes
the warning to fire on legitimate code, and the warning is now firing
and scaring people for no good reason.
Reported-by: default avatarIvan Delalande <colona@arista.com>
Reported-by: default avatarOmar Sandoval <osandov@osandov.com>
Fixes: f48cfddc ("vfs: In d_path don't call d_dname on a mount point")
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
[ vlee: Backported to 3.10. Adjusted context. ]
Signed-off-by: default avatarVinson Lee <vlee@twitter.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d0550a3f
...@@ -2569,15 +2569,6 @@ static int prepend_path(const struct path *path, ...@@ -2569,15 +2569,6 @@ static int prepend_path(const struct path *path,
return error; return error;
global_root: global_root:
/*
* Filesystems needing to implement special "root names"
* should do so with ->d_dname()
*/
if (IS_ROOT(dentry) &&
(dentry->d_name.len != 1 || dentry->d_name.name[0] != '/')) {
WARN(1, "Root dentry has weird name <%.*s>\n",
(int) dentry->d_name.len, dentry->d_name.name);
}
if (!slash) if (!slash)
error = prepend(buffer, buflen, "/", 1); error = prepend(buffer, buflen, "/", 1);
if (!error) if (!error)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment