Commit e696cda7 authored by Vlad Yasevich's avatar Vlad Yasevich Committed by David S. Miller

macvlan: Fix passthru macvlan mac address inheritance

When a lower device of the passthru macvlan changes it's address,
passthru macvlan is supposed to change it's own address as well.
However, that doesn't happen correctly because the check in
macvlan_addr_busy() will catch the fact that the lower level
(port) mac address is the same as the address we are trying to
assign to the macvlan, and return an error.  As a reasult,
the address of the passthru macvlan device is never changed.

The same thing happens when the user attempts to change the
mac address of the passthru macvlan.

The simple solution appers to be to not check against
the lower device in case of passthru macvlan device, since
the 2 addresses are _supposed_ to be the same.
Signed-off-by: default avatarVladislav Yasevich <vyasevic@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e26f43fa
...@@ -185,7 +185,8 @@ static bool macvlan_addr_busy(const struct macvlan_port *port, ...@@ -185,7 +185,8 @@ static bool macvlan_addr_busy(const struct macvlan_port *port,
* currently in use by the underlying device or * currently in use by the underlying device or
* another macvlan. * another macvlan.
*/ */
if (ether_addr_equal_64bits(port->dev->dev_addr, addr)) if (!port->passthru &&
ether_addr_equal_64bits(port->dev->dev_addr, addr))
return true; return true;
if (macvlan_hash_lookup(port, addr)) if (macvlan_hash_lookup(port, addr))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment