Commit e69f6186 authored by Yacine Belkadi's avatar Yacine Belkadi Committed by Ingo Molnar

sched: Fix some kernel-doc warnings

When building the htmldocs (in verbose mode), scripts/kernel-doc
reports the follwing type of warnings:

  Warning(kernel/sched/core.c:936): No description found for return value of 'task_curr'
  ...

Fix those by:

 - adding the missing descriptions
 - using "Return" sections for the descriptions
Signed-off-by: default avatarYacine Belkadi <yacine.belkadi.1@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1373654747-2389-1-git-send-email-yacine.belkadi.1@gmail.com
[ While at it, fix the cpupri_set() explanation. ]
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 61f98b0f
...@@ -1532,6 +1532,8 @@ static inline pid_t task_pgrp_nr(struct task_struct *tsk) ...@@ -1532,6 +1532,8 @@ static inline pid_t task_pgrp_nr(struct task_struct *tsk)
* Test if a process is not yet dead (at most zombie state) * Test if a process is not yet dead (at most zombie state)
* If pid_alive fails, then pointers within the task structure * If pid_alive fails, then pointers within the task structure
* can be stale and must not be dereferenced. * can be stale and must not be dereferenced.
*
* Return: 1 if the process is alive. 0 otherwise.
*/ */
static inline int pid_alive(struct task_struct *p) static inline int pid_alive(struct task_struct *p)
{ {
...@@ -1543,6 +1545,8 @@ static inline int pid_alive(struct task_struct *p) ...@@ -1543,6 +1545,8 @@ static inline int pid_alive(struct task_struct *p)
* @tsk: Task structure to be checked. * @tsk: Task structure to be checked.
* *
* Check if a task structure is the first user space task the kernel created. * Check if a task structure is the first user space task the kernel created.
*
* Return: 1 if the task structure is init. 0 otherwise.
*/ */
static inline int is_global_init(struct task_struct *tsk) static inline int is_global_init(struct task_struct *tsk)
{ {
...@@ -1893,6 +1897,8 @@ extern struct task_struct *idle_task(int cpu); ...@@ -1893,6 +1897,8 @@ extern struct task_struct *idle_task(int cpu);
/** /**
* is_idle_task - is the specified task an idle task? * is_idle_task - is the specified task an idle task?
* @p: the task in question. * @p: the task in question.
*
* Return: 1 if @p is an idle task. 0 otherwise.
*/ */
static inline bool is_idle_task(const struct task_struct *p) static inline bool is_idle_task(const struct task_struct *p)
{ {
......
This diff is collapsed.
...@@ -62,7 +62,7 @@ static int convert_prio(int prio) ...@@ -62,7 +62,7 @@ static int convert_prio(int prio)
* any discrepancies created by racing against the uncertainty of the current * any discrepancies created by racing against the uncertainty of the current
* priority configuration. * priority configuration.
* *
* Returns: (int)bool - CPUs were found * Return: (int)bool - CPUs were found
*/ */
int cpupri_find(struct cpupri *cp, struct task_struct *p, int cpupri_find(struct cpupri *cp, struct task_struct *p,
struct cpumask *lowest_mask) struct cpumask *lowest_mask)
...@@ -203,7 +203,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri) ...@@ -203,7 +203,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
* cpupri_init - initialize the cpupri structure * cpupri_init - initialize the cpupri structure
* @cp: The cpupri context * @cp: The cpupri context
* *
* Returns: -ENOMEM if memory fails. * Return: -ENOMEM on memory allocation failure.
*/ */
int cpupri_init(struct cpupri *cp) int cpupri_init(struct cpupri *cp)
{ {
......
...@@ -4280,6 +4280,8 @@ struct sg_lb_stats { ...@@ -4280,6 +4280,8 @@ struct sg_lb_stats {
* get_sd_load_idx - Obtain the load index for a given sched domain. * get_sd_load_idx - Obtain the load index for a given sched domain.
* @sd: The sched_domain whose load_idx is to be obtained. * @sd: The sched_domain whose load_idx is to be obtained.
* @idle: The Idle status of the CPU for whose sd load_icx is obtained. * @idle: The Idle status of the CPU for whose sd load_icx is obtained.
*
* Return: The load index.
*/ */
static inline int get_sd_load_idx(struct sched_domain *sd, static inline int get_sd_load_idx(struct sched_domain *sd,
enum cpu_idle_type idle) enum cpu_idle_type idle)
...@@ -4574,6 +4576,9 @@ static inline void update_sg_lb_stats(struct lb_env *env, ...@@ -4574,6 +4576,9 @@ static inline void update_sg_lb_stats(struct lb_env *env,
* *
* Determine if @sg is a busier group than the previously selected * Determine if @sg is a busier group than the previously selected
* busiest group. * busiest group.
*
* Return: %true if @sg is a busier group than the previously selected
* busiest group. %false otherwise.
*/ */
static bool update_sd_pick_busiest(struct lb_env *env, static bool update_sd_pick_busiest(struct lb_env *env,
struct sd_lb_stats *sds, struct sd_lb_stats *sds,
...@@ -4691,7 +4696,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, ...@@ -4691,7 +4696,7 @@ static inline void update_sd_lb_stats(struct lb_env *env,
* assuming lower CPU number will be equivalent to lower a SMT thread * assuming lower CPU number will be equivalent to lower a SMT thread
* number. * number.
* *
* Returns 1 when packing is required and a task should be moved to * Return: 1 when packing is required and a task should be moved to
* this CPU. The amount of the imbalance is returned in *imbalance. * this CPU. The amount of the imbalance is returned in *imbalance.
* *
* @env: The load balancing environment. * @env: The load balancing environment.
...@@ -4869,7 +4874,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s ...@@ -4869,7 +4874,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
* @balance: Pointer to a variable indicating if this_cpu * @balance: Pointer to a variable indicating if this_cpu
* is the appropriate cpu to perform load balancing at this_level. * is the appropriate cpu to perform load balancing at this_level.
* *
* Returns: - the busiest group if imbalance exists. * Return: - The busiest group if imbalance exists.
* - If no imbalance and user has opted for power-savings balance, * - If no imbalance and user has opted for power-savings balance,
* return the least loaded group whose CPUs can be * return the least loaded group whose CPUs can be
* put to idle by rebalancing its tasks onto our group. * put to idle by rebalancing its tasks onto our group.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment