Commit e78e5a91 authored by Samuel Neves's avatar Samuel Neves Committed by Thomas Gleixner

x86/vdso: Fix lsl operand order

In the __getcpu function, lsl is using the wrong target and destination
registers. Luckily, the compiler tends to choose %eax for both variables,
so it has been working so far.

Fixes: a582c540 ("x86/vdso: Use RDPID in preference to LSL when available")
Signed-off-by: default avatarSamuel Neves <sneves@dei.uc.pt>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarAndy Lutomirski <luto@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20180901201452.27828-1-sneves@dei.uc.pt
parent c7486104
...@@ -93,7 +93,7 @@ static inline unsigned int __getcpu(void) ...@@ -93,7 +93,7 @@ static inline unsigned int __getcpu(void)
* *
* If RDPID is available, use it. * If RDPID is available, use it.
*/ */
alternative_io ("lsl %[p],%[seg]", alternative_io ("lsl %[seg],%[p]",
".byte 0xf3,0x0f,0xc7,0xf8", /* RDPID %eax/rax */ ".byte 0xf3,0x0f,0xc7,0xf8", /* RDPID %eax/rax */
X86_FEATURE_RDPID, X86_FEATURE_RDPID,
[p] "=a" (p), [seg] "r" (__PER_CPU_SEG)); [p] "=a" (p), [seg] "r" (__PER_CPU_SEG));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment