Commit e7c470a4 authored by Dave Airlie's avatar Dave Airlie

Merge tag 'exynos-drm-fixes-v5.17-rc6' of...

Merge tag 'exynos-drm-fixes-v5.17-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes

Fixups
- Make display controller drivers for Exynos series to use
  platform_get_irq and platform_get_irq_byname functions
  to get the interrupt, which prevents irq chaning from messed up
  when using hierarchical interrupt domains which use "interrupts"
  property in the node.
- Fix two regressions to TE-gpio handling.
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>

From: Inki Dae <inki.dae@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220225014042.17637-1-inki.dae@samsung.com
parents 7e57714c 4188db23
...@@ -678,7 +678,6 @@ static int decon_probe(struct platform_device *pdev) ...@@ -678,7 +678,6 @@ static int decon_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct decon_context *ctx; struct decon_context *ctx;
struct device_node *i80_if_timings; struct device_node *i80_if_timings;
struct resource *res;
int ret; int ret;
if (!dev->of_node) if (!dev->of_node)
...@@ -728,16 +727,11 @@ static int decon_probe(struct platform_device *pdev) ...@@ -728,16 +727,11 @@ static int decon_probe(struct platform_device *pdev)
goto err_iounmap; goto err_iounmap;
} }
res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, ret = platform_get_irq_byname(pdev, ctx->i80_if ? "lcd_sys" : "vsync");
ctx->i80_if ? "lcd_sys" : "vsync"); if (ret < 0)
if (!res) {
dev_err(dev, "irq request failed.\n");
ret = -ENXIO;
goto err_iounmap; goto err_iounmap;
}
ret = devm_request_irq(dev, res->start, decon_irq_handler, ret = devm_request_irq(dev, ret, decon_irq_handler, 0, "drm_decon", ctx);
0, "drm_decon", ctx);
if (ret) { if (ret) {
dev_err(dev, "irq request failed.\n"); dev_err(dev, "irq request failed.\n");
goto err_iounmap; goto err_iounmap;
......
...@@ -1334,8 +1334,10 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi, ...@@ -1334,8 +1334,10 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
int ret; int ret;
int te_gpio_irq; int te_gpio_irq;
dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN); dsi->te_gpio = gpiod_get_optional(panel, "te", GPIOD_IN);
if (IS_ERR(dsi->te_gpio)) { if (!dsi->te_gpio) {
return 0;
} else if (IS_ERR(dsi->te_gpio)) {
dev_err(dsi->dev, "gpio request failed with %ld\n", dev_err(dsi->dev, "gpio request failed with %ld\n",
PTR_ERR(dsi->te_gpio)); PTR_ERR(dsi->te_gpio));
return PTR_ERR(dsi->te_gpio); return PTR_ERR(dsi->te_gpio);
......
...@@ -1267,7 +1267,6 @@ static int fimc_probe(struct platform_device *pdev) ...@@ -1267,7 +1267,6 @@ static int fimc_probe(struct platform_device *pdev)
struct exynos_drm_ipp_formats *formats; struct exynos_drm_ipp_formats *formats;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct fimc_context *ctx; struct fimc_context *ctx;
struct resource *res;
int ret; int ret;
int i, j, num_limits, num_formats; int i, j, num_limits, num_formats;
...@@ -1330,13 +1329,11 @@ static int fimc_probe(struct platform_device *pdev) ...@@ -1330,13 +1329,11 @@ static int fimc_probe(struct platform_device *pdev)
return PTR_ERR(ctx->regs); return PTR_ERR(ctx->regs);
/* resource irq */ /* resource irq */
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); ret = platform_get_irq(pdev, 0);
if (!res) { if (ret < 0)
dev_err(dev, "failed to request irq resource.\n"); return ret;
return -ENOENT;
}
ret = devm_request_irq(dev, res->start, fimc_irq_handler, ret = devm_request_irq(dev, ret, fimc_irq_handler,
0, dev_name(dev), ctx); 0, dev_name(dev), ctx);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "failed to request irq.\n"); dev_err(dev, "failed to request irq.\n");
......
...@@ -1133,7 +1133,6 @@ static int fimd_probe(struct platform_device *pdev) ...@@ -1133,7 +1133,6 @@ static int fimd_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct fimd_context *ctx; struct fimd_context *ctx;
struct device_node *i80_if_timings; struct device_node *i80_if_timings;
struct resource *res;
int ret; int ret;
if (!dev->of_node) if (!dev->of_node)
...@@ -1206,15 +1205,11 @@ static int fimd_probe(struct platform_device *pdev) ...@@ -1206,15 +1205,11 @@ static int fimd_probe(struct platform_device *pdev)
if (IS_ERR(ctx->regs)) if (IS_ERR(ctx->regs))
return PTR_ERR(ctx->regs); return PTR_ERR(ctx->regs);
res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, ret = platform_get_irq_byname(pdev, ctx->i80_if ? "lcd_sys" : "vsync");
ctx->i80_if ? "lcd_sys" : "vsync"); if (ret < 0)
if (!res) { return ret;
dev_err(dev, "irq request failed.\n");
return -ENXIO;
}
ret = devm_request_irq(dev, res->start, fimd_irq_handler, ret = devm_request_irq(dev, ret, fimd_irq_handler, 0, "drm_fimd", ctx);
0, "drm_fimd", ctx);
if (ret) { if (ret) {
dev_err(dev, "irq request failed.\n"); dev_err(dev, "irq request failed.\n");
return ret; return ret;
......
...@@ -1220,7 +1220,6 @@ static int gsc_probe(struct platform_device *pdev) ...@@ -1220,7 +1220,6 @@ static int gsc_probe(struct platform_device *pdev)
struct gsc_driverdata *driver_data; struct gsc_driverdata *driver_data;
struct exynos_drm_ipp_formats *formats; struct exynos_drm_ipp_formats *formats;
struct gsc_context *ctx; struct gsc_context *ctx;
struct resource *res;
int num_formats, ret, i, j; int num_formats, ret, i, j;
ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
...@@ -1275,13 +1274,10 @@ static int gsc_probe(struct platform_device *pdev) ...@@ -1275,13 +1274,10 @@ static int gsc_probe(struct platform_device *pdev)
return PTR_ERR(ctx->regs); return PTR_ERR(ctx->regs);
/* resource irq */ /* resource irq */
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); ctx->irq = platform_get_irq(pdev, 0);
if (!res) { if (ctx->irq < 0)
dev_err(dev, "failed to request irq resource.\n"); return ctx->irq;
return -ENOENT;
}
ctx->irq = res->start;
ret = devm_request_irq(dev, ctx->irq, gsc_irq_handler, 0, ret = devm_request_irq(dev, ctx->irq, gsc_irq_handler, 0,
dev_name(dev), ctx); dev_name(dev), ctx);
if (ret < 0) { if (ret < 0) {
......
...@@ -809,19 +809,17 @@ static int mixer_resources_init(struct mixer_context *mixer_ctx) ...@@ -809,19 +809,17 @@ static int mixer_resources_init(struct mixer_context *mixer_ctx)
return -ENXIO; return -ENXIO;
} }
res = platform_get_resource(mixer_ctx->pdev, IORESOURCE_IRQ, 0); ret = platform_get_irq(mixer_ctx->pdev, 0);
if (res == NULL) { if (ret < 0)
dev_err(dev, "get interrupt resource failed.\n"); return ret;
return -ENXIO; mixer_ctx->irq = ret;
}
ret = devm_request_irq(dev, res->start, mixer_irq_handler, ret = devm_request_irq(dev, mixer_ctx->irq, mixer_irq_handler,
0, "drm_mixer", mixer_ctx); 0, "drm_mixer", mixer_ctx);
if (ret) { if (ret) {
dev_err(dev, "request interrupt failed.\n"); dev_err(dev, "request interrupt failed.\n");
return ret; return ret;
} }
mixer_ctx->irq = res->start;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment