Commit e7e2afea authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra Committed by Mark Brown

ASoC: amd: AMD RV RT5682 should depends on CROS_EC

If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:

 WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
 WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL

 ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
 i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
 ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
 cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
 ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
 cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'

This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
both depends on CROS_EC.

Fixes: 6b8e4e7d ("ASoC: amd: Add machine driver for Raven based platform")
Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200303110514.3267126-1-enric.balletbo@collabora.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent cd1fa301
...@@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH ...@@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
select SND_SOC_MAX98357A select SND_SOC_MAX98357A
select SND_SOC_CROS_EC_CODEC select SND_SOC_CROS_EC_CODEC
select I2C_CROS_EC_TUNNEL select I2C_CROS_EC_TUNNEL
depends on SND_SOC_AMD_ACP3x && I2C depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
help help
This option enables machine driver for RT5682 and MAX9835. This option enables machine driver for RT5682 and MAX9835.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment