Commit e7f4c4bf authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

pinctrl: ingenic: checking for NULL instead of IS_ERR()

devm_pinctrl_register() returns error pointers, it doesn't return NULL.

Fixes: b5c23aa4 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1bd303dc
...@@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev) ...@@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev)
} }
jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc); jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc);
if (!jzpc->pctl) { if (IS_ERR(jzpc->pctl)) {
dev_err(dev, "Failed to register pinctrl\n"); dev_err(dev, "Failed to register pinctrl\n");
return -EINVAL; return PTR_ERR(jzpc->pctl);
} }
for (i = 0; i < chip_info->num_groups; i++) { for (i = 0; i < chip_info->num_groups; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment