Commit e8429b09 authored by Monam Agarwal's avatar Monam Agarwal Committed by Greg Kroah-Hartman

drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by: default avatarMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb790747
...@@ -1807,7 +1807,7 @@ static void fwserial_release_port(struct fwtty_port *port, bool reset) ...@@ -1807,7 +1807,7 @@ static void fwserial_release_port(struct fwtty_port *port, bool reset)
port->max_payload = link_speed_to_max_payload(SCODE_100); port->max_payload = link_speed_to_max_payload(SCODE_100);
dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload); dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload);
rcu_assign_pointer(port->peer, NULL); RCU_INIT_POINTER(port->peer, NULL);
spin_unlock_bh(&port->lock); spin_unlock_bh(&port->lock);
if (port->port.console && port->fwcon_ops->notify != NULL) if (port->port.console && port->fwcon_ops->notify != NULL)
...@@ -2240,7 +2240,7 @@ static int fwserial_create(struct fw_unit *unit) ...@@ -2240,7 +2240,7 @@ static int fwserial_create(struct fw_unit *unit)
port->max_payload = link_speed_to_max_payload(SCODE_100); port->max_payload = link_speed_to_max_payload(SCODE_100);
dma_fifo_init(&port->tx_fifo); dma_fifo_init(&port->tx_fifo);
rcu_assign_pointer(port->peer, NULL); RCU_INIT_POINTER(port->peer, NULL);
serial->ports[i] = port; serial->ports[i] = port;
/* get unique bus addr region for port's status & recv fifo */ /* get unique bus addr region for port's status & recv fifo */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment