Commit e8871186 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'media/v4.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media

Pull media fixes from Mauro Carvalho Chehab:

 - dvb-usb-firmware: don't do DMA on stack

 - coda/imx-vdoa: platform_driver should not be const

 - bdisp: Clean up file handle in open() error path

 - exynos-gsc: Do not swap cb/cr for semi planar formats

* tag 'media/v4.11-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media:
  [media] exynos-gsc: Do not swap cb/cr for semi planar formats
  [media] bdisp: Clean up file handle in open() error path
  [media] coda/imx-vdoa: platform_driver should not be const
  [media] dvb-usb-firmware: don't do DMA on stack
parents 86b7eab2 24a47426
...@@ -321,7 +321,7 @@ static const struct of_device_id vdoa_dt_ids[] = { ...@@ -321,7 +321,7 @@ static const struct of_device_id vdoa_dt_ids[] = {
}; };
MODULE_DEVICE_TABLE(of, vdoa_dt_ids); MODULE_DEVICE_TABLE(of, vdoa_dt_ids);
static const struct platform_driver vdoa_driver = { static struct platform_driver vdoa_driver = {
.probe = vdoa_probe, .probe = vdoa_probe,
.remove = vdoa_remove, .remove = vdoa_remove,
.driver = { .driver = {
......
...@@ -861,9 +861,7 @@ int gsc_prepare_addr(struct gsc_ctx *ctx, struct vb2_buffer *vb, ...@@ -861,9 +861,7 @@ int gsc_prepare_addr(struct gsc_ctx *ctx, struct vb2_buffer *vb,
if ((frame->fmt->pixelformat == V4L2_PIX_FMT_VYUY) || if ((frame->fmt->pixelformat == V4L2_PIX_FMT_VYUY) ||
(frame->fmt->pixelformat == V4L2_PIX_FMT_YVYU) || (frame->fmt->pixelformat == V4L2_PIX_FMT_YVYU) ||
(frame->fmt->pixelformat == V4L2_PIX_FMT_NV61) ||
(frame->fmt->pixelformat == V4L2_PIX_FMT_YVU420) || (frame->fmt->pixelformat == V4L2_PIX_FMT_YVU420) ||
(frame->fmt->pixelformat == V4L2_PIX_FMT_NV21) ||
(frame->fmt->pixelformat == V4L2_PIX_FMT_YVU420M)) (frame->fmt->pixelformat == V4L2_PIX_FMT_YVU420M))
swap(addr->cb, addr->cr); swap(addr->cb, addr->cr);
......
...@@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) ...@@ -632,8 +632,8 @@ static int bdisp_open(struct file *file)
error_ctrls: error_ctrls:
bdisp_ctrls_delete(ctx); bdisp_ctrls_delete(ctx);
error_fh:
v4l2_fh_del(&ctx->fh); v4l2_fh_del(&ctx->fh);
error_fh:
v4l2_fh_exit(&ctx->fh); v4l2_fh_exit(&ctx->fh);
bdisp_hw_free_nodes(ctx); bdisp_hw_free_nodes(ctx);
mem_ctx: mem_ctx:
......
...@@ -36,16 +36,18 @@ static int usb_cypress_writemem(struct usb_device *udev,u16 addr,u8 *data, u8 le ...@@ -36,16 +36,18 @@ static int usb_cypress_writemem(struct usb_device *udev,u16 addr,u8 *data, u8 le
int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw, int type) int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw, int type)
{ {
struct hexline *hx; struct hexline *hx;
u8 reset; u8 *buf;
int ret,pos=0; int ret, pos = 0;
u16 cpu_cs_register = cypress[type].cpu_cs_register;
hx = kmalloc(sizeof(*hx), GFP_KERNEL); buf = kmalloc(sizeof(*hx), GFP_KERNEL);
if (!hx) if (!buf)
return -ENOMEM; return -ENOMEM;
hx = (struct hexline *)buf;
/* stop the CPU */ /* stop the CPU */
reset = 1; buf[0] = 1;
if ((ret = usb_cypress_writemem(udev,cypress[type].cpu_cs_register,&reset,1)) != 1) if (usb_cypress_writemem(udev, cpu_cs_register, buf, 1) != 1)
err("could not stop the USB controller CPU."); err("could not stop the USB controller CPU.");
while ((ret = dvb_usb_get_hexline(fw, hx, &pos)) > 0) { while ((ret = dvb_usb_get_hexline(fw, hx, &pos)) > 0) {
...@@ -61,21 +63,21 @@ int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw ...@@ -61,21 +63,21 @@ int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw
} }
if (ret < 0) { if (ret < 0) {
err("firmware download failed at %d with %d",pos,ret); err("firmware download failed at %d with %d",pos,ret);
kfree(hx); kfree(buf);
return ret; return ret;
} }
if (ret == 0) { if (ret == 0) {
/* restart the CPU */ /* restart the CPU */
reset = 0; buf[0] = 0;
if (ret || usb_cypress_writemem(udev,cypress[type].cpu_cs_register,&reset,1) != 1) { if (usb_cypress_writemem(udev, cpu_cs_register, buf, 1) != 1) {
err("could not restart the USB controller CPU."); err("could not restart the USB controller CPU.");
ret = -EINVAL; ret = -EINVAL;
} }
} else } else
ret = -EIO; ret = -EIO;
kfree(hx); kfree(buf);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment