Commit e938b9c9 authored by Wanpeng Li's avatar Wanpeng Li Committed by Ingo Molnar

sched/nohz: Optimize get_nohz_timer_target()

On a machine, CPU 0 is used for housekeeping, the other 39 CPUs in the
same socket are in nohz_full mode. We can observe huge time burn in the
loop for seaching nearest busy housekeeper cpu by ftrace.

  2)               |                        get_nohz_timer_target() {
  2)   0.240 us    |                          housekeeping_test_cpu();
  2)   0.458 us    |                          housekeeping_test_cpu();

  ...

  2)   0.292 us    |                          housekeeping_test_cpu();
  2)   0.240 us    |                          housekeeping_test_cpu();
  2)   0.227 us    |                          housekeeping_any_cpu();
  2) + 43.460 us   |                        }

This patch optimizes the searching logic by finding a nearest housekeeper
CPU in the housekeeping cpumask, it can minimize the worst searching time
from ~44us to < 10us in my testing. In addition, the last iterated busy
housekeeper can become a random candidate while current CPU is a better
fallback if it is a housekeeper.
Signed-off-by: default avatarWanpeng Li <wanpengli@tencent.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Link: https://lkml.kernel.org/r/1578876627-11938-1-git-send-email-wanpengli@tencent.com
parent b562d140
...@@ -552,27 +552,32 @@ void resched_cpu(int cpu) ...@@ -552,27 +552,32 @@ void resched_cpu(int cpu)
*/ */
int get_nohz_timer_target(void) int get_nohz_timer_target(void)
{ {
int i, cpu = smp_processor_id(); int i, cpu = smp_processor_id(), default_cpu = -1;
struct sched_domain *sd; struct sched_domain *sd;
if (!idle_cpu(cpu) && housekeeping_cpu(cpu, HK_FLAG_TIMER)) if (housekeeping_cpu(cpu, HK_FLAG_TIMER)) {
if (!idle_cpu(cpu))
return cpu; return cpu;
default_cpu = cpu;
}
rcu_read_lock(); rcu_read_lock();
for_each_domain(cpu, sd) { for_each_domain(cpu, sd) {
for_each_cpu(i, sched_domain_span(sd)) { for_each_cpu_and(i, sched_domain_span(sd),
housekeeping_cpumask(HK_FLAG_TIMER)) {
if (cpu == i) if (cpu == i)
continue; continue;
if (!idle_cpu(i) && housekeeping_cpu(i, HK_FLAG_TIMER)) { if (!idle_cpu(i)) {
cpu = i; cpu = i;
goto unlock; goto unlock;
} }
} }
} }
if (!housekeeping_cpu(cpu, HK_FLAG_TIMER)) if (default_cpu == -1)
cpu = housekeeping_any_cpu(HK_FLAG_TIMER); default_cpu = housekeeping_any_cpu(HK_FLAG_TIMER);
cpu = default_cpu;
unlock: unlock:
rcu_read_unlock(); rcu_read_unlock();
return cpu; return cpu;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment