Commit e976a725 authored by Hans Verkuil's avatar Hans Verkuil Committed by Greg Kroah-Hartman

carma-fpga-program.c: fix compile errors

drivers/misc/carma/carma-fpga-program.c: In function 'fpga_program_dma':
drivers/misc/carma/carma-fpga-program.c:529:2: error: expected ';' before 'if'
  if (ret) {
  ^
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_read':
drivers/misc/carma/carma-fpga-program.c:752:45: error: 'ppos' undeclared (first use in this function)
  return simple_read_from_buffer(buf, count, ppos,
                                             ^
drivers/misc/carma/carma-fpga-program.c:752:45: note: each undeclared identifier is reported only once for each function it appears in
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_llseek':
drivers/misc/carma/carma-fpga-program.c:765:27: error: 'file' undeclared (first use in this function)
  return fixed_size_llseek(file, offset, origin, priv->fw_size);
                           ^
drivers/misc/carma/carma-fpga-program.c:759:9: warning: unused variable 'newpos' [-Wunused-variable]
  loff_t newpos;
         ^
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_read':
drivers/misc/carma/carma-fpga-program.c:754:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_llseek':
drivers/misc/carma/carma-fpga-program.c:766:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
scripts/Makefile.build:263: recipe for target 'drivers/misc/carma/carma-fpga-program.o' failed
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 723493ca
...@@ -525,7 +525,7 @@ static noinline int fpga_program_dma(struct fpga_dev *priv) ...@@ -525,7 +525,7 @@ static noinline int fpga_program_dma(struct fpga_dev *priv)
goto out_dma_unmap; goto out_dma_unmap;
} }
ret = fsl_dma_external_start(chan, 1) ret = fsl_dma_external_start(chan, 1);
if (ret) { if (ret) {
dev_err(priv->dev, "DMA external control setup failed\n"); dev_err(priv->dev, "DMA external control setup failed\n");
goto out_dma_unmap; goto out_dma_unmap;
...@@ -749,20 +749,19 @@ static ssize_t fpga_read(struct file *filp, char __user *buf, size_t count, ...@@ -749,20 +749,19 @@ static ssize_t fpga_read(struct file *filp, char __user *buf, size_t count,
loff_t *f_pos) loff_t *f_pos)
{ {
struct fpga_dev *priv = filp->private_data; struct fpga_dev *priv = filp->private_data;
return simple_read_from_buffer(buf, count, ppos, return simple_read_from_buffer(buf, count, f_pos,
priv->vb.vaddr, priv->bytes); priv->vb.vaddr, priv->bytes);
} }
static loff_t fpga_llseek(struct file *filp, loff_t offset, int origin) static loff_t fpga_llseek(struct file *filp, loff_t offset, int origin)
{ {
struct fpga_dev *priv = filp->private_data; struct fpga_dev *priv = filp->private_data;
loff_t newpos;
/* only read-only opens are allowed to seek */ /* only read-only opens are allowed to seek */
if ((filp->f_flags & O_ACCMODE) != O_RDONLY) if ((filp->f_flags & O_ACCMODE) != O_RDONLY)
return -EINVAL; return -EINVAL;
return fixed_size_llseek(file, offset, origin, priv->fw_size); return fixed_size_llseek(filp, offset, origin, priv->fw_size);
} }
static const struct file_operations fpga_fops = { static const struct file_operations fpga_fops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment