Commit eab6ee1c authored by Martin K. Petersen's avatar Martin K. Petersen Committed by Tejun Heo

libata: Fix regression when the NCQ Send and Receive log page is absent

Commit 5d3abf8f ("libata: Fall back to unqueued READ LOG EXT if
the DMA variant fails") allowed us to fall back to the unqueued READ
LOG variant if the queued version failed. However, if the device did
not support the page at all we would end up looping due to a merge
snafu.

Ensure we only take the fallback path once.
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reported-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Tested-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 6ec0a86c
...@@ -1521,6 +1521,7 @@ unsigned int ata_read_log_page(struct ata_device *dev, u8 log, ...@@ -1521,6 +1521,7 @@ unsigned int ata_read_log_page(struct ata_device *dev, u8 log,
} else { } else {
tf.command = ATA_CMD_READ_LOG_EXT; tf.command = ATA_CMD_READ_LOG_EXT;
tf.protocol = ATA_PROT_PIO; tf.protocol = ATA_PROT_PIO;
dma = false;
} }
tf.lbal = log; tf.lbal = log;
tf.lbam = page; tf.lbam = page;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment