Commit eae06553 authored by Brent Lu's avatar Brent Lu Committed by Mark Brown

ASoC: Intel: avs-rt298: remove redundant dapm routes

Two routes "AIF1 Playback<-sspX Tx" and "sspX Rx<-AIF1 Capture" are
created by snd_soc_dapm_connect_dai_link_widgets() automatically.
Remove the duplicate routes.
Signed-off-by: default avatarBrent Lu <brent.lu@intel.com>
Link: https://lore.kernel.org/r/20230612110958.592674-11-brent.lu@intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent cca1ac1f
...@@ -178,38 +178,6 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in ...@@ -178,38 +178,6 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in
return 0; return 0;
} }
static int avs_create_dapm_routes(struct device *dev, int ssp_port,
struct snd_soc_dapm_route **routes, int *num_routes)
{
struct snd_soc_dapm_route *dr;
const int num_base = ARRAY_SIZE(card_base_routes);
const int num_dr = num_base + 2;
int idx;
dr = devm_kcalloc(dev, num_dr, sizeof(*dr), GFP_KERNEL);
if (!dr)
return -ENOMEM;
memcpy(dr, card_base_routes, num_base * sizeof(*dr));
idx = num_base;
dr[idx].sink = devm_kasprintf(dev, GFP_KERNEL, "AIF1 Playback");
dr[idx].source = devm_kasprintf(dev, GFP_KERNEL, "ssp%d Tx", ssp_port);
if (!dr[idx].sink || !dr[idx].source)
return -ENOMEM;
idx++;
dr[idx].sink = devm_kasprintf(dev, GFP_KERNEL, "ssp%d Rx", ssp_port);
dr[idx].source = devm_kasprintf(dev, GFP_KERNEL, "AIF1 Capture");
if (!dr[idx].sink || !dr[idx].source)
return -ENOMEM;
*routes = dr;
*num_routes = num_dr;
return 0;
}
static int avs_card_suspend_pre(struct snd_soc_card *card) static int avs_card_suspend_pre(struct snd_soc_card *card)
{ {
struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, RT298_CODEC_DAI); struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, RT298_CODEC_DAI);
...@@ -227,14 +195,13 @@ static int avs_card_resume_post(struct snd_soc_card *card) ...@@ -227,14 +195,13 @@ static int avs_card_resume_post(struct snd_soc_card *card)
static int avs_rt298_probe(struct platform_device *pdev) static int avs_rt298_probe(struct platform_device *pdev)
{ {
struct snd_soc_dapm_route *routes;
struct snd_soc_dai_link *dai_link; struct snd_soc_dai_link *dai_link;
struct snd_soc_acpi_mach *mach; struct snd_soc_acpi_mach *mach;
struct snd_soc_card *card; struct snd_soc_card *card;
struct snd_soc_jack *jack; struct snd_soc_jack *jack;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
const char *pname; const char *pname;
int num_routes, ssp_port, ret; int ssp_port, ret;
mach = dev_get_platdata(dev); mach = dev_get_platdata(dev);
pname = mach->mach_params.platform; pname = mach->mach_params.platform;
...@@ -246,12 +213,6 @@ static int avs_rt298_probe(struct platform_device *pdev) ...@@ -246,12 +213,6 @@ static int avs_rt298_probe(struct platform_device *pdev)
return ret; return ret;
} }
ret = avs_create_dapm_routes(dev, ssp_port, &routes, &num_routes);
if (ret) {
dev_err(dev, "Failed to create dapm routes: %d", ret);
return ret;
}
jack = devm_kzalloc(dev, sizeof(*jack), GFP_KERNEL); jack = devm_kzalloc(dev, sizeof(*jack), GFP_KERNEL);
card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
if (!jack || !card) if (!jack || !card)
...@@ -268,8 +229,8 @@ static int avs_rt298_probe(struct platform_device *pdev) ...@@ -268,8 +229,8 @@ static int avs_rt298_probe(struct platform_device *pdev)
card->num_controls = ARRAY_SIZE(card_controls); card->num_controls = ARRAY_SIZE(card_controls);
card->dapm_widgets = card_widgets; card->dapm_widgets = card_widgets;
card->num_dapm_widgets = ARRAY_SIZE(card_widgets); card->num_dapm_widgets = ARRAY_SIZE(card_widgets);
card->dapm_routes = routes; card->dapm_routes = card_base_routes;
card->num_dapm_routes = num_routes; card->num_dapm_routes = ARRAY_SIZE(card_base_routes);
card->fully_routed = true; card->fully_routed = true;
snd_soc_card_set_drvdata(card, jack); snd_soc_card_set_drvdata(card, jack);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment