Commit eb32c896 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller

net: hns3: adjust the timing of hns3_client_stop when unloading

hns3_client_stop() should be called after unregister_netdev(),
otherwise the ongoing reset task may start the client just after it.

Fixes: a6d818e3 ("net: hns3: Add vport alive state checking support")
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc645dfa
...@@ -3718,13 +3718,13 @@ static void hns3_client_uninit(struct hnae3_handle *handle, bool reset) ...@@ -3718,13 +3718,13 @@ static void hns3_client_uninit(struct hnae3_handle *handle, bool reset)
struct hns3_nic_priv *priv = netdev_priv(netdev); struct hns3_nic_priv *priv = netdev_priv(netdev);
int ret; int ret;
hns3_client_stop(handle);
hns3_remove_hw_addr(netdev); hns3_remove_hw_addr(netdev);
if (netdev->reg_state != NETREG_UNINITIALIZED) if (netdev->reg_state != NETREG_UNINITIALIZED)
unregister_netdev(netdev); unregister_netdev(netdev);
hns3_client_stop(handle);
if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) { if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) {
netdev_warn(netdev, "already uninitialized\n"); netdev_warn(netdev, "already uninitialized\n");
goto out_netdev_free; goto out_netdev_free;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment