Commit eb9c87a4 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Adrian Bunk

[NETPOLL]: Fix TX queue overflow in trapped mode.

CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in
the netpoll's "trapped" mode which easily causes overflows in the drivers with
short TX queues (most notably, in 8139too with its 4-deep queue).  So, make
this option more sensible by making it only bypass the TX softirq wakeup.
Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
Acked-by: default avatarJeff Garzik <jgarzik@pobox.com>
Acked-by: default avatarTom Rini <trini@kernel.crashing.org>
Acked-by: default avatarMatt Mackall <mpm@selenic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent 57b0c610
...@@ -623,8 +623,10 @@ static inline void netif_start_queue(struct net_device *dev) ...@@ -623,8 +623,10 @@ static inline void netif_start_queue(struct net_device *dev)
static inline void netif_wake_queue(struct net_device *dev) static inline void netif_wake_queue(struct net_device *dev)
{ {
#ifdef CONFIG_NETPOLL_TRAP #ifdef CONFIG_NETPOLL_TRAP
if (netpoll_trap()) if (netpoll_trap()) {
clear_bit(__LINK_STATE_XOFF, &dev->state);
return; return;
}
#endif #endif
if (test_and_clear_bit(__LINK_STATE_XOFF, &dev->state)) if (test_and_clear_bit(__LINK_STATE_XOFF, &dev->state))
__netif_schedule(dev); __netif_schedule(dev);
...@@ -632,10 +634,6 @@ static inline void netif_wake_queue(struct net_device *dev) ...@@ -632,10 +634,6 @@ static inline void netif_wake_queue(struct net_device *dev)
static inline void netif_stop_queue(struct net_device *dev) static inline void netif_stop_queue(struct net_device *dev)
{ {
#ifdef CONFIG_NETPOLL_TRAP
if (netpoll_trap())
return;
#endif
set_bit(__LINK_STATE_XOFF, &dev->state); set_bit(__LINK_STATE_XOFF, &dev->state);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment