Commit ebeae54d authored by Jakub Kicinski's avatar Jakub Kicinski

net: pcs: xpcs: depends on PHYLINK in Kconfig

This is yet another attempt at fixing:

>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!

Switch XPCS to be invisible, as Russell points out it's
"selected" by its consumers. Drop the dependency on MDIO_BUS
as "depends" is meaningless on "selected" symbols.
Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: b47aec88 ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Link: https://lore.kernel.org/netdev/20220620201915.1195280-1-kuba@kernel.org/
Link: https://lore.kernel.org/r/20220622083521.0de3ea5c@kernel.org/
Link: https://lore.kernel.org/r/20220623202933.2341938-1-kuba@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 97a4d46b
...@@ -6,8 +6,8 @@ ...@@ -6,8 +6,8 @@
menu "PCS device drivers" menu "PCS device drivers"
config PCS_XPCS config PCS_XPCS
tristate "Synopsys DesignWare XPCS controller" tristate
depends on MDIO_DEVICE && MDIO_BUS select PHYLINK
help help
This module provides helper functions for Synopsys DesignWare XPCS This module provides helper functions for Synopsys DesignWare XPCS
controllers. controllers.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment