Commit ec5a32f6 authored by Luca Tettamanti's avatar Luca Tettamanti Committed by David S. Miller

atl1: fix resume

adapter->cmb.cmb is initialized when the device is opened and freed when
it's closed. Accessing it unconditionally during resume results either
in a crash (NULL pointer dereference, when the interface has not been
opened yet) or data corruption (when the interface has been used and
brought down adapter->cmb.cmb points to a deallocated memory area).

Cc: stable@kernel.org
Signed-off-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
Acked-by: default avatarChris Snook <chris.snook@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56b49f4b
...@@ -2847,10 +2847,11 @@ static int atl1_resume(struct pci_dev *pdev) ...@@ -2847,10 +2847,11 @@ static int atl1_resume(struct pci_dev *pdev)
pci_enable_wake(pdev, PCI_D3cold, 0); pci_enable_wake(pdev, PCI_D3cold, 0);
atl1_reset_hw(&adapter->hw); atl1_reset_hw(&adapter->hw);
adapter->cmb.cmb->int_stats = 0;
if (netif_running(netdev)) if (netif_running(netdev)) {
adapter->cmb.cmb->int_stats = 0;
atl1_up(adapter); atl1_up(adapter);
}
netif_device_attach(netdev); netif_device_attach(netdev);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment