Commit ecadffd7 authored by Yue Hu's avatar Yue Hu Committed by Greg Kroah-Hartman

mm/cma_debug.c: fix the break condition in cma_maxchunk_get()

[ Upstream commit f0fd5050 ]

If not find zero bit in find_next_zero_bit(), it will return the size
parameter passed in, so the start bit should be compared with bitmap_maxno
rather than cma->count.  Although getting maxchunk is working fine due to
zero value of order_per_bit currently, the operation will be stuck if
order_per_bit is set as non-zero.

Link: http://lkml.kernel.org/r/20190319092734.276-1-zbestahu@gmail.comSigned-off-by: default avatarYue Hu <huyue2@yulong.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Joe Perches <joe@perches.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Dmitry Safonov <d.safonov@partner.samsung.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 397b073f
...@@ -56,7 +56,7 @@ static int cma_maxchunk_get(void *data, u64 *val) ...@@ -56,7 +56,7 @@ static int cma_maxchunk_get(void *data, u64 *val)
mutex_lock(&cma->lock); mutex_lock(&cma->lock);
for (;;) { for (;;) {
start = find_next_zero_bit(cma->bitmap, bitmap_maxno, end); start = find_next_zero_bit(cma->bitmap, bitmap_maxno, end);
if (start >= cma->count) if (start >= bitmap_maxno)
break; break;
end = find_next_bit(cma->bitmap, bitmap_maxno, start); end = find_next_bit(cma->bitmap, bitmap_maxno, start);
maxchunk = max(end - start, maxchunk); maxchunk = max(end - start, maxchunk);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment