Commit ed01385c authored by Martin KaFai Lau's avatar Martin KaFai Lau Committed by Daniel Borkmann

selftests/bpf: Use ASSERT_EQ instead ASSERT_OK for testing memcmp result

In tcp_hdr_options test, it ensures the received tcp hdr option
and the sk local storage have the expected values. It uses memcmp
to check that. Testing the memcmp result with ASSERT_OK is confusing
because ASSERT_OK will print out the errno which is not set.
This patch uses ASSERT_EQ to check for 0 instead.
Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarYonghong Song <yhs@fb.com>
Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20230316000726.1016773-1-martin.lau@linux.dev
parent 72fe61d7
...@@ -151,7 +151,7 @@ static int check_hdr_opt(const struct bpf_test_option *exp, ...@@ -151,7 +151,7 @@ static int check_hdr_opt(const struct bpf_test_option *exp,
const struct bpf_test_option *act, const struct bpf_test_option *act,
const char *hdr_desc) const char *hdr_desc)
{ {
if (!ASSERT_OK(memcmp(exp, act, sizeof(*exp)), hdr_desc)) { if (!ASSERT_EQ(memcmp(exp, act, sizeof(*exp)), 0, hdr_desc)) {
print_option(exp, "expected: "); print_option(exp, "expected: ");
print_option(act, " actual: "); print_option(act, " actual: ");
return -1; return -1;
...@@ -169,7 +169,7 @@ static int check_hdr_stg(const struct hdr_stg *exp, int fd, ...@@ -169,7 +169,7 @@ static int check_hdr_stg(const struct hdr_stg *exp, int fd,
"map_lookup(hdr_stg_map_fd)")) "map_lookup(hdr_stg_map_fd)"))
return -1; return -1;
if (!ASSERT_OK(memcmp(exp, &act, sizeof(*exp)), stg_desc)) { if (!ASSERT_EQ(memcmp(exp, &act, sizeof(*exp)), 0, stg_desc)) {
print_hdr_stg(exp, "expected: "); print_hdr_stg(exp, "expected: ");
print_hdr_stg(&act, " actual: "); print_hdr_stg(&act, " actual: ");
return -1; return -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment