Commit ed829857 authored by David Daney's avatar David Daney Committed by Gleb Natapov

mips/kvm: Use ENOIOCTLCMD to indicate unimplemented ioctls.

The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested.  Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: default avatarDavid Daney <david.daney@cavium.com>
Acked-by: default avatarSanjay Lal <sanjayl@kymasys.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 4c73fb2b
...@@ -195,7 +195,7 @@ void kvm_arch_destroy_vm(struct kvm *kvm) ...@@ -195,7 +195,7 @@ void kvm_arch_destroy_vm(struct kvm *kvm)
long long
kvm_arch_dev_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg) kvm_arch_dev_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
{ {
return -EINVAL; return -ENOIOCTLCMD;
} }
void kvm_arch_free_memslot(struct kvm_memory_slot *free, void kvm_arch_free_memslot(struct kvm_memory_slot *free,
...@@ -401,7 +401,7 @@ int ...@@ -401,7 +401,7 @@ int
kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
struct kvm_guest_debug *dbg) struct kvm_guest_debug *dbg)
{ {
return -EINVAL; return -ENOIOCTLCMD;
} }
int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run) int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run)
...@@ -475,14 +475,14 @@ int ...@@ -475,14 +475,14 @@ int
kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu, kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
struct kvm_mp_state *mp_state) struct kvm_mp_state *mp_state)
{ {
return -EINVAL; return -ENOIOCTLCMD;
} }
int int
kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu, kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
struct kvm_mp_state *mp_state) struct kvm_mp_state *mp_state)
{ {
return -EINVAL; return -ENOIOCTLCMD;
} }
#define KVM_REG_MIPS_CP0_INDEX (0x10000 + 8 * 0 + 0) #define KVM_REG_MIPS_CP0_INDEX (0x10000 + 8 * 0 + 0)
...@@ -801,7 +801,7 @@ long kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg) ...@@ -801,7 +801,7 @@ long kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
switch (ioctl) { switch (ioctl) {
default: default:
r = -EINVAL; r = -ENOIOCTLCMD;
} }
return r; return r;
...@@ -829,13 +829,13 @@ void kvm_arch_exit(void) ...@@ -829,13 +829,13 @@ void kvm_arch_exit(void)
int int
kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs) kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs)
{ {
return -ENOTSUPP; return -ENOIOCTLCMD;
} }
int int
kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs) kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs)
{ {
return -ENOTSUPP; return -ENOIOCTLCMD;
} }
int kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) int kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
...@@ -845,12 +845,12 @@ int kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) ...@@ -845,12 +845,12 @@ int kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu) int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
{ {
return -ENOTSUPP; return -ENOIOCTLCMD;
} }
int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu) int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
{ {
return -ENOTSUPP; return -ENOIOCTLCMD;
} }
int kvm_arch_vcpu_fault(struct kvm_vcpu *vcpu, struct vm_fault *vmf) int kvm_arch_vcpu_fault(struct kvm_vcpu *vcpu, struct vm_fault *vmf)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment