Commit edb03203 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Jiri Kosina

HID: hid-sensor-hub: Return error for hid_set_field() failure

In the function sensor_hub_set_feature(), return error when hid_set_field()
fails.
Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent b45ef5db
...@@ -209,16 +209,21 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id, ...@@ -209,16 +209,21 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
buffer_size = buffer_size / sizeof(__s32); buffer_size = buffer_size / sizeof(__s32);
if (buffer_size) { if (buffer_size) {
for (i = 0; i < buffer_size; ++i) { for (i = 0; i < buffer_size; ++i) {
hid_set_field(report->field[field_index], i, ret = hid_set_field(report->field[field_index], i,
(__force __s32)cpu_to_le32(*buf32)); (__force __s32)cpu_to_le32(*buf32));
if (ret)
goto done_proc;
++buf32; ++buf32;
} }
} }
if (remaining_bytes) { if (remaining_bytes) {
value = 0; value = 0;
memcpy(&value, (u8 *)buf32, remaining_bytes); memcpy(&value, (u8 *)buf32, remaining_bytes);
hid_set_field(report->field[field_index], i, ret = hid_set_field(report->field[field_index], i,
(__force __s32)cpu_to_le32(value)); (__force __s32)cpu_to_le32(value));
if (ret)
goto done_proc;
} }
hid_hw_request(hsdev->hdev, report, HID_REQ_SET_REPORT); hid_hw_request(hsdev->hdev, report, HID_REQ_SET_REPORT);
hid_hw_wait(hsdev->hdev); hid_hw_wait(hsdev->hdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment