Commit ee088ed7 authored by Jeff Layton's avatar Jeff Layton Committed by Christian Brauner

tty: convert to new timestamp accessors

Convert to using the new inode timestamp accessor functions.
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Link: https://lore.kernel.org/r/20231004185347.80880-9-jlayton@kernel.orgSigned-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent d524e9d6
...@@ -818,7 +818,7 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) ...@@ -818,7 +818,7 @@ static void tty_update_time(struct tty_struct *tty, bool mtime)
spin_lock(&tty->files_lock); spin_lock(&tty->files_lock);
list_for_each_entry(priv, &tty->tty_files, list) { list_for_each_entry(priv, &tty->tty_files, list) {
struct inode *inode = file_inode(priv->file); struct inode *inode = file_inode(priv->file);
struct timespec64 *time = mtime ? &inode->i_mtime : &inode->i_atime; struct timespec64 time = mtime ? inode_get_mtime(inode) : inode_get_atime(inode);
/* /*
* We only care if the two values differ in anything other than the * We only care if the two values differ in anything other than the
...@@ -826,8 +826,12 @@ static void tty_update_time(struct tty_struct *tty, bool mtime) ...@@ -826,8 +826,12 @@ static void tty_update_time(struct tty_struct *tty, bool mtime)
* the time of the tty device, otherwise it could be construded as a * the time of the tty device, otherwise it could be construded as a
* security leak to let userspace know the exact timing of the tty. * security leak to let userspace know the exact timing of the tty.
*/ */
if ((sec ^ time->tv_sec) & ~7) if ((sec ^ time.tv_sec) & ~7) {
time->tv_sec = sec; if (mtime)
inode_set_mtime(inode, sec, 0);
else
inode_set_atime(inode, sec, 0);
}
} }
spin_unlock(&tty->files_lock); spin_unlock(&tty->files_lock);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment