Commit f011b313 authored by Youssef Samir's avatar Youssef Samir Committed by Paolo Abeni

net: qrtr: Update packets cloning when broadcasting

When broadcasting data to multiple nodes via MHI, using skb_clone()
causes all nodes to receive the same header data. This can result in
packets being discarded by endpoints, leading to lost data.

This issue occurs when a socket is closed, and a QRTR_TYPE_DEL_CLIENT
packet is broadcasted. All nodes receive the same destination node ID,
causing the node connected to the client to discard the packet and
remain unaware of the client's deletion.

Replace skb_clone() with pskb_copy(), to create a separate copy of
the header for each sk_buff.

Fixes: bdabad3e ("net: Add Qualcomm IPC router")
Signed-off-by: default avatarYoussef Samir <quic_yabdulra@quicinc.com>
Reviewed-by: default avatarJeffery Hugo <quic_jhugo@quicinc.com>
Reviewed-by: default avatarCarl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: default avatarChris Lew <quic_clew@quicinc.com>
Link: https://patch.msgid.link/20240916170858.2382247-1-quic_yabdulra@quicinc.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c8770db2
...@@ -884,7 +884,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb, ...@@ -884,7 +884,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb,
mutex_lock(&qrtr_node_lock); mutex_lock(&qrtr_node_lock);
list_for_each_entry(node, &qrtr_all_nodes, item) { list_for_each_entry(node, &qrtr_all_nodes, item) {
skbn = skb_clone(skb, GFP_KERNEL); skbn = pskb_copy(skb, GFP_KERNEL);
if (!skbn) if (!skbn)
break; break;
skb_set_owner_w(skbn, skb->sk); skb_set_owner_w(skbn, skb->sk);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment