Commit f067074b authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Alexei Starovoitov

selftests/bpf: Update LLVM Phabricator links

reviews.llvm.org was LLVM's Phabricator instances for code review. It
has been abandoned in favor of GitHub pull requests. While the majority
of links in the kernel sources still work because of the work Fangrui
has done turning the dynamic Phabricator instance into a static archive,
there are some issues with that work, so preemptively convert all the
links in the kernel sources to point to the commit on GitHub.

Most of the commits have the corresponding differential review link in
the commit message itself so there should not be any loss of fidelity in
the relevant information.

Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while
in the area.

Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20240111-bpf-update-llvm-phabricator-links-v2-1-9a7ae976bd64@kernel.orgSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 56d3e44a
...@@ -115,7 +115,7 @@ the insn 20 undoes map_value addition. It is currently impossible for the ...@@ -115,7 +115,7 @@ the insn 20 undoes map_value addition. It is currently impossible for the
verifier to understand such speculative pointer arithmetic. verifier to understand such speculative pointer arithmetic.
Hence `this patch`__ addresses it on the compiler side. It was committed on llvm 12. Hence `this patch`__ addresses it on the compiler side. It was committed on llvm 12.
__ https://reviews.llvm.org/D85570 __ https://github.com/llvm/llvm-project/commit/ddf1864ace484035e3cde5e83b3a31ac81e059c6
The corresponding C code The corresponding C code
...@@ -165,7 +165,7 @@ This is due to a llvm BPF backend bug. `The fix`__ ...@@ -165,7 +165,7 @@ This is due to a llvm BPF backend bug. `The fix`__
has been pushed to llvm 10.x release branch and will be has been pushed to llvm 10.x release branch and will be
available in 10.0.1. The patch is available in llvm 11.0.0 trunk. available in 10.0.1. The patch is available in llvm 11.0.0 trunk.
__ https://reviews.llvm.org/D78466 __ https://github.com/llvm/llvm-project/commit/3cb7e7bf959dcd3b8080986c62e10a75c7af43f0
bpf_verif_scale/loop6.bpf.o test failure with Clang 12 bpf_verif_scale/loop6.bpf.o test failure with Clang 12
====================================================== ======================================================
...@@ -204,7 +204,7 @@ r5(w5) is eventually saved on stack at insn #24 for later use. ...@@ -204,7 +204,7 @@ r5(w5) is eventually saved on stack at insn #24 for later use.
This cause later verifier failure. The bug has been `fixed`__ in This cause later verifier failure. The bug has been `fixed`__ in
Clang 13. Clang 13.
__ https://reviews.llvm.org/D97479 __ https://github.com/llvm/llvm-project/commit/1959ead525b8830cc8a345f45e1c3ef9902d3229
BPF CO-RE-based tests and Clang version BPF CO-RE-based tests and Clang version
======================================= =======================================
...@@ -221,11 +221,11 @@ failures: ...@@ -221,11 +221,11 @@ failures:
- __builtin_btf_type_id() [0_, 1_, 2_]; - __builtin_btf_type_id() [0_, 1_, 2_];
- __builtin_preserve_type_info(), __builtin_preserve_enum_value() [3_, 4_]. - __builtin_preserve_type_info(), __builtin_preserve_enum_value() [3_, 4_].
.. _0: https://reviews.llvm.org/D74572 .. _0: https://github.com/llvm/llvm-project/commit/6b01b465388b204d543da3cf49efd6080db094a9
.. _1: https://reviews.llvm.org/D74668 .. _1: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f
.. _2: https://reviews.llvm.org/D85174 .. _2: https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99
.. _3: https://reviews.llvm.org/D83878 .. _3: https://github.com/llvm/llvm-project/commit/6d218b4adb093ff2e9764febbbc89f429412006c
.. _4: https://reviews.llvm.org/D83242 .. _4: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8
Floating-point tests and Clang version Floating-point tests and Clang version
====================================== ======================================
...@@ -234,7 +234,7 @@ Certain selftests, e.g. core_reloc, require support for the floating-point ...@@ -234,7 +234,7 @@ Certain selftests, e.g. core_reloc, require support for the floating-point
types, which was introduced in `Clang 13`__. The older Clang versions will types, which was introduced in `Clang 13`__. The older Clang versions will
either crash when compiling these tests, or generate an incorrect BTF. either crash when compiling these tests, or generate an incorrect BTF.
__ https://reviews.llvm.org/D83289 __ https://github.com/llvm/llvm-project/commit/a7137b238a07d9399d3ae96c0b461571bd5aa8b2
Kernel function call test and Clang version Kernel function call test and Clang version
=========================================== ===========================================
...@@ -248,7 +248,7 @@ Without it, the error from compiling bpf selftests looks like: ...@@ -248,7 +248,7 @@ Without it, the error from compiling bpf selftests looks like:
libbpf: failed to find BTF for extern 'tcp_slow_start' [25] section: -2 libbpf: failed to find BTF for extern 'tcp_slow_start' [25] section: -2
__ https://reviews.llvm.org/D93563 __ https://github.com/llvm/llvm-project/commit/886f9ff53155075bd5f1e994f17b85d1e1b7470c
btf_tag test and Clang version btf_tag test and Clang version
============================== ==============================
...@@ -264,8 +264,8 @@ Without them, the btf_tag selftest will be skipped and you will observe: ...@@ -264,8 +264,8 @@ Without them, the btf_tag selftest will be skipped and you will observe:
#<test_num> btf_tag:SKIP #<test_num> btf_tag:SKIP
.. _0: https://reviews.llvm.org/D111588 .. _0: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6
.. _1: https://reviews.llvm.org/D111199 .. _1: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784
Clang dependencies for static linking tests Clang dependencies for static linking tests
=========================================== ===========================================
...@@ -274,7 +274,7 @@ linked_vars, linked_maps, and linked_funcs tests depend on `Clang fix`__ to ...@@ -274,7 +274,7 @@ linked_vars, linked_maps, and linked_funcs tests depend on `Clang fix`__ to
generate valid BTF information for weak variables. Please make sure you use generate valid BTF information for weak variables. Please make sure you use
Clang that contains the fix. Clang that contains the fix.
__ https://reviews.llvm.org/D100362 __ https://github.com/llvm/llvm-project/commit/968292cb93198442138128d850fd54dc7edc0035
Clang relocation changes Clang relocation changes
======================== ========================
...@@ -292,7 +292,7 @@ Here, ``type 2`` refers to new relocation type ``R_BPF_64_ABS64``. ...@@ -292,7 +292,7 @@ Here, ``type 2`` refers to new relocation type ``R_BPF_64_ABS64``.
To fix this issue, user newer libbpf. To fix this issue, user newer libbpf.
.. Links .. Links
.. _clang reloc patch: https://reviews.llvm.org/D102712 .. _clang reloc patch: https://github.com/llvm/llvm-project/commit/6a2ea84600ba4bd3b2733bd8f08f5115eb32164b
.. _kernel llvm reloc: /Documentation/bpf/llvm_reloc.rst .. _kernel llvm reloc: /Documentation/bpf/llvm_reloc.rst
Clang dependencies for the u32 spill test (xdpwall) Clang dependencies for the u32 spill test (xdpwall)
...@@ -304,6 +304,6 @@ from running test_progs will look like: ...@@ -304,6 +304,6 @@ from running test_progs will look like:
.. code-block:: console .. code-block:: console
test_xdpwall:FAIL:Does LLVM have https://reviews.llvm.org/D109073? unexpected error: -4007 test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5? unexpected error: -4007
__ https://reviews.llvm.org/D109073 __ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5
...@@ -9,7 +9,7 @@ void test_xdpwall(void) ...@@ -9,7 +9,7 @@ void test_xdpwall(void)
struct xdpwall *skel; struct xdpwall *skel;
skel = xdpwall__open_and_load(); skel = xdpwall__open_and_load();
ASSERT_OK_PTR(skel, "Does LLMV have https://reviews.llvm.org/D109073?"); ASSERT_OK_PTR(skel, "Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5?");
xdpwall__destroy(skel); xdpwall__destroy(skel);
} }
...@@ -80,7 +80,7 @@ int test_core_type_id(void *ctx) ...@@ -80,7 +80,7 @@ int test_core_type_id(void *ctx)
* to detect whether this test has to be executed, however strange * to detect whether this test has to be executed, however strange
* that might look like. * that might look like.
* *
* [0] https://reviews.llvm.org/D85174 * [0] https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99
*/ */
#if __has_builtin(__builtin_preserve_type_info) #if __has_builtin(__builtin_preserve_type_info)
struct core_reloc_type_id_output *out = (void *)&data.out; struct core_reloc_type_id_output *out = (void *)&data.out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment