Commit f108b2de authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Revert "usb: gadget: composite: always set ep->mult to a sensible value"

This reverts commit c53af76d which is
commit eaa496ff upstream as it was
incorrect.
Reported-by: default avatarBin Liu <b-liu@ti.com>
Cc: Felipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6053479c
...@@ -148,12 +148,7 @@ int config_ep_by_speed(struct usb_gadget *g, ...@@ -148,12 +148,7 @@ int config_ep_by_speed(struct usb_gadget *g,
_ep->desc = chosen_desc; _ep->desc = chosen_desc;
_ep->comp_desc = NULL; _ep->comp_desc = NULL;
_ep->maxburst = 0; _ep->maxburst = 0;
_ep->mult = 1; _ep->mult = 0;
if (g->speed == USB_SPEED_HIGH && (usb_endpoint_xfer_isoc(_ep->desc) ||
usb_endpoint_xfer_int(_ep->desc)))
_ep->mult = usb_endpoint_maxp(_ep->desc) & 0x7ff;
if (!want_comp_desc) if (!want_comp_desc)
return 0; return 0;
...@@ -170,7 +165,7 @@ int config_ep_by_speed(struct usb_gadget *g, ...@@ -170,7 +165,7 @@ int config_ep_by_speed(struct usb_gadget *g,
switch (usb_endpoint_type(_ep->desc)) { switch (usb_endpoint_type(_ep->desc)) {
case USB_ENDPOINT_XFER_ISOC: case USB_ENDPOINT_XFER_ISOC:
/* mult: bits 1:0 of bmAttributes */ /* mult: bits 1:0 of bmAttributes */
_ep->mult = (comp_desc->bmAttributes & 0x3) + 1; _ep->mult = comp_desc->bmAttributes & 0x3;
case USB_ENDPOINT_XFER_BULK: case USB_ENDPOINT_XFER_BULK:
case USB_ENDPOINT_XFER_INT: case USB_ENDPOINT_XFER_INT:
_ep->maxburst = comp_desc->bMaxBurst + 1; _ep->maxburst = comp_desc->bMaxBurst + 1;
......
...@@ -243,7 +243,7 @@ uvc_video_alloc_requests(struct uvc_video *video) ...@@ -243,7 +243,7 @@ uvc_video_alloc_requests(struct uvc_video *video)
req_size = video->ep->maxpacket req_size = video->ep->maxpacket
* max_t(unsigned int, video->ep->maxburst, 1) * max_t(unsigned int, video->ep->maxburst, 1)
* (video->ep->mult); * (video->ep->mult + 1);
for (i = 0; i < UVC_NUM_REQUESTS; ++i) { for (i = 0; i < UVC_NUM_REQUESTS; ++i) {
video->req_buffer[i] = kmalloc(req_size, GFP_KERNEL); video->req_buffer[i] = kmalloc(req_size, GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment