Commit f124345e authored by Kent Overstreet's avatar Kent Overstreet Committed by Kent Overstreet

bcachefs: Drop bch2_journal_meta() call when going RW

Back when we relied on the journal sequence number blacklist machinery
for consistency between btree and the journal, we needed to ensure a new
journal entry was written before any btree writes were done. But, this
had the side effect of consuming some space in the journal prior to
doing journal replay - which could lead to a very wedged filesystem,
since we don't yet have a way to grow the journal prior to going RW.

Fortunately, the journal sequence number blacklist machinery isn't
needed anymore, as btree node pointers now record the numer of sectors
currently written to that node - that code should all be ripped out.
Signed-off-by: default avatarKent Overstreet <kent.overstreet@gmail.com>
parent 2027875b
...@@ -412,13 +412,6 @@ static int __bch2_fs_read_write(struct bch_fs *c, bool early) ...@@ -412,13 +412,6 @@ static int __bch2_fs_read_write(struct bch_fs *c, bool early)
if (ret) if (ret)
goto err; goto err;
/*
* We need to write out a journal entry before we start doing btree
* updates, to ensure that on unclean shutdown new journal blacklist
* entries are created:
*/
bch2_journal_meta(&c->journal);
clear_bit(BCH_FS_ALLOC_CLEAN, &c->flags); clear_bit(BCH_FS_ALLOC_CLEAN, &c->flags);
for_each_rw_member(ca, c, i) for_each_rw_member(ca, c, i)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment