Commit f1441318 authored by Matthew Garrett's avatar Matthew Garrett Committed by Linus Torvalds

eeepc-laptop: fix use after free

eeepc-laptop uses the hwmon struct after unregistering the device, causing
an oops on module unload.  Flip the ordering to fix.
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Karol Kozimor <sziwan@users.sourceforge.net>
Cc: <stable@kernel.org>		[2.6.26.x]
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0c7281c0
...@@ -553,9 +553,9 @@ static void eeepc_hwmon_exit(void) ...@@ -553,9 +553,9 @@ static void eeepc_hwmon_exit(void)
hwmon = eeepc_hwmon_device; hwmon = eeepc_hwmon_device;
if (!hwmon) if (!hwmon)
return ; return ;
hwmon_device_unregister(hwmon);
sysfs_remove_group(&hwmon->kobj, sysfs_remove_group(&hwmon->kobj,
&hwmon_attribute_group); &hwmon_attribute_group);
hwmon_device_unregister(hwmon);
eeepc_hwmon_device = NULL; eeepc_hwmon_device = NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment