Commit f16214c1 authored by Matthieu Baerts's avatar Matthieu Baerts Committed by Andrii Nakryiko

bpf: Fix 'dubious one-bit signed bitfield' warnings

Our CI[1] reported these warnings when using Sparse:

  $ touch net/mptcp/bpf.c
  $ make C=1 net/mptcp/bpf.o
  net/mptcp/bpf.c: note: in included file:
  include/linux/bpf_verifier.h:348:26: error: dubious one-bit signed bitfield
  include/linux/bpf_verifier.h:349:29: error: dubious one-bit signed bitfield

Set them as 'unsigned' to avoid warnings.

[1] https://github.com/multipath-tcp/mptcp_net-next/actions/runs/2643588487

Fixes: 1ade2371 ("bpf: Inline calls to bpf_loop when callback is known")
Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Acked-by: default avatarYonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20220711081200.2081262-1-matthieu.baerts@tessares.net
parent 49705c4a
...@@ -345,10 +345,10 @@ struct bpf_verifier_state_list { ...@@ -345,10 +345,10 @@ struct bpf_verifier_state_list {
}; };
struct bpf_loop_inline_state { struct bpf_loop_inline_state {
int initialized:1; /* set to true upon first entry */ unsigned int initialized:1; /* set to true upon first entry */
int fit_for_inline:1; /* true if callback function is the same unsigned int fit_for_inline:1; /* true if callback function is the same
* at each call and flags are always zero * at each call and flags are always zero
*/ */
u32 callback_subprogno; /* valid when fit_for_inline is true */ u32 callback_subprogno; /* valid when fit_for_inline is true */
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment