Commit f1ebbe4c authored by Markus Elfring's avatar Markus Elfring Committed by Helge Deller

fbdev: omapfb: Call of_node_put(ep) only once in omapdss_of_find_source_for_first_ep()

An of_node_put(ep) call was immediately used after a pointer check
for a of_graph_get_remote_port() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 5b97eebc
...@@ -129,12 +129,9 @@ omapdss_of_find_source_for_first_ep(struct device_node *node) ...@@ -129,12 +129,9 @@ omapdss_of_find_source_for_first_ep(struct device_node *node)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
src_port = of_graph_get_remote_port(ep); src_port = of_graph_get_remote_port(ep);
if (!src_port) {
of_node_put(ep);
return ERR_PTR(-EINVAL);
}
of_node_put(ep); of_node_put(ep);
if (!src_port)
return ERR_PTR(-EINVAL);
src = omap_dss_find_output_by_port_node(src_port); src = omap_dss_find_output_by_port_node(src_port);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment