Commit f22cf8eb authored by Dan Carpenter's avatar Dan Carpenter Committed by Rusty Russell

virtio-blk: fix NULL checking in virtblk_alloc_req()

Smatch complains about the inconsistent NULL checking here.  Fix it to
return NULL on failure.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (fixed accidental deletion)
parent c85a1f91
...@@ -90,10 +90,12 @@ static inline struct virtblk_req *virtblk_alloc_req(struct virtio_blk *vblk, ...@@ -90,10 +90,12 @@ static inline struct virtblk_req *virtblk_alloc_req(struct virtio_blk *vblk,
struct virtblk_req *vbr; struct virtblk_req *vbr;
vbr = mempool_alloc(vblk->pool, gfp_mask); vbr = mempool_alloc(vblk->pool, gfp_mask);
if (vbr && use_bio) if (!vbr)
sg_init_table(vbr->sg, vblk->sg_elems); return NULL;
vbr->vblk = vblk; vbr->vblk = vblk;
if (use_bio)
sg_init_table(vbr->sg, vblk->sg_elems);
return vbr; return vbr;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment