Skip to content

L
linux
Commit f27db8eb authored by Finn Thain's avatar Finn Thain Committed by Martin K. Petersen
Browse files
Options

ncr5380: Fix autosense bugs 

NCR5380_information_transfer() may re-queue a command for autosense,
after calling scsi_eh_prep_cmnd(). This creates several possibilities:

1. Reselection may intervene before the re-queued command gets processed.
   If the reconnected command then undergoes autosense, this causes the
   scsi_eh_save data from the previous command to be overwritten.

2. After NCR5380_information_transfer() calls scsi_eh_prep_cmnd(),
   a new REQUEST SENSE command may arrive. This would be queued ahead
   of any command already undergoing autosense, which means the
   scsi_eh_save data might be restored to the wrong command.

3. After NCR5380_information_transfer() calls scsi_eh_prep_cmnd(),
   eh_abort_handler() may abort the command. But the scsi_eh_save data is
   not discarded, which means the scsi_eh_save data might be incorrectly
   restored to the next REQUEST SENSE command issued.

This patch adds a new autosense list so that commands that are re-queued
because of a CHECK CONDITION result can be kept apart from the REQUEST
SENSE commands that arrive via queuecommand.

This patch also adds a function dedicated to dequeueing and preparing the
next command for processing. By refactoring the main loop in this way,
scsi_eh_save takes place when an autosense command is dequeued rather
than when re-queued.
Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Tested-by: default avatarOndrej Zary <linux@rainbow-software.org>
Tested-by: default avatarMichael Schmitz <schmitzmic@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 677e0194
Show whitespace changes
Inline Side-by-side
Showing with 249 additions and 186 deletions
drivers/scsi/NCR5380.c
View file @ f27db8eb
...@@ -244,6 +244,9 @@ static inline void initialize_SCp(struct scsi_cmnd *cmd) ...@@ -244,6 +244,9 @@ static inline void initialize_SCp(struct scsi_cmnd *cmd)
cmd->SCp.ptr = NULL; cmd->SCp.ptr = NULL;
cmd->SCp.this_residual = 0; cmd->SCp.this_residual = 0;
} }
cmd->SCp.Status = 0;
cmd->SCp.Message = 0;
} }
/** /**
...@@ -622,6 +625,8 @@ static int NCR5380_init(struct Scsi_Host *instance, int flags) ...@@ -622,6 +625,8 @@ static int NCR5380_init(struct Scsi_Host *instance, int flags)
#endif #endif
spin_lock_init(&hostdata->lock); spin_lock_init(&hostdata->lock);
hostdata->connected = NULL; hostdata->connected = NULL;
hostdata->sensing = NULL;
INIT_LIST_HEAD(&hostdata->autosense);
INIT_LIST_HEAD(&hostdata->unissued); INIT_LIST_HEAD(&hostdata->unissued);
INIT_LIST_HEAD(&hostdata->disconnected); INIT_LIST_HEAD(&hostdata->disconnected);
...@@ -738,6 +743,16 @@ static void complete_cmd(struct Scsi_Host *instance, ...@@ -738,6 +743,16 @@ static void complete_cmd(struct Scsi_Host *instance,
dsprintk(NDEBUG_QUEUES, instance, "complete_cmd: cmd %p\n", cmd); dsprintk(NDEBUG_QUEUES, instance, "complete_cmd: cmd %p\n", cmd);
if (hostdata->sensing == cmd) {
/* Autosense processing ends here */
if ((cmd->result & 0xff) != SAM_STAT_GOOD) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
set_host_byte(cmd, DID_ERROR);
} else
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
hostdata->sensing = NULL;
}
hostdata->busy[scmd_id(cmd)] &= ~(1 << cmd->device->lun); hostdata->busy[scmd_id(cmd)] &= ~(1 << cmd->device->lun);
cmd->scsi_done(cmd); cmd->scsi_done(cmd);
...@@ -797,6 +812,64 @@ static int NCR5380_queue_command(struct Scsi_Host *instance, ...@@ -797,6 +812,64 @@ static int NCR5380_queue_command(struct Scsi_Host *instance,
return 0; return 0;
} }
/**
* dequeue_next_cmd - dequeue a command for processing
* @instance: the scsi host instance
*
* Priority is given to commands on the autosense queue. These commands
* need autosense because of a CHECK CONDITION result.
*
* Returns a command pointer if a command is found for a target that is
* not already busy. Otherwise returns NULL.
*/
static struct scsi_cmnd *dequeue_next_cmd(struct Scsi_Host *instance)
{
struct NCR5380_hostdata *hostdata = shost_priv(instance);
struct NCR5380_cmd *ncmd;
struct scsi_cmnd *cmd;
if (list_empty(&hostdata->autosense)) {
list_for_each_entry(ncmd, &hostdata->unissued, list) {
cmd = NCR5380_to_scmd(ncmd);
dsprintk(NDEBUG_QUEUES, instance, "dequeue: cmd=%p target=%d busy=0x%02x lun=%llu\n",
cmd, scmd_id(cmd), hostdata->busy[scmd_id(cmd)], cmd->device->lun);
if (!(hostdata->busy[scmd_id(cmd)] & (1 << cmd->device->lun))) {
list_del(&ncmd->list);
dsprintk(NDEBUG_QUEUES, instance,
"dequeue: removed %p from issue queue\n", cmd);
return cmd;
}
}
} else {
/* Autosense processing begins here */
ncmd = list_first_entry(&hostdata->autosense,
struct NCR5380_cmd, list);
list_del(&ncmd->list);
cmd = NCR5380_to_scmd(ncmd);
dsprintk(NDEBUG_QUEUES, instance,
"dequeue: removed %p from autosense queue\n", cmd);
scsi_eh_prep_cmnd(cmd, &hostdata->ses, NULL, 0, ~0);
hostdata->sensing = cmd;
return cmd;
}
return NULL;
}
static void requeue_cmd(struct Scsi_Host *instance, struct scsi_cmnd *cmd)
{
struct NCR5380_hostdata *hostdata = shost_priv(instance);
struct NCR5380_cmd *ncmd = scsi_cmd_priv(cmd);
if (hostdata->sensing) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
list_add(&ncmd->list, &hostdata->autosense);
hostdata->sensing = NULL;
} else
list_add(&ncmd->list, &hostdata->unissued);
}
/** /**
* NCR5380_main - NCR state machines * NCR5380_main - NCR state machines
* *
...@@ -814,33 +887,17 @@ static void NCR5380_main(struct work_struct *work) ...@@ -814,33 +887,17 @@ static void NCR5380_main(struct work_struct *work)
struct NCR5380_hostdata *hostdata = struct NCR5380_hostdata *hostdata =
container_of(work, struct NCR5380_hostdata, main_task); container_of(work, struct NCR5380_hostdata, main_task);
struct Scsi_Host *instance = hostdata->host; struct Scsi_Host *instance = hostdata->host;
struct NCR5380_cmd *ncmd, *n; struct scsi_cmnd *cmd;
int done; int done;
spin_lock_irq(&hostdata->lock); spin_lock_irq(&hostdata->lock);
do { do {
done = 1; done = 1;
if (!hostdata->connected) { while (!hostdata->connected &&
dprintk(NDEBUG_MAIN, "scsi%d : not connected\n", instance->host_no); (cmd = dequeue_next_cmd(instance))) {
/*
* Search through the issue_queue for a command destined dsprintk(NDEBUG_MAIN, instance, "main: dequeued %p\n", cmd);
* for a target that's not busy.
*/
list_for_each_entry_safe(ncmd, n, &hostdata->unissued,
list) {
struct scsi_cmnd *tmp = NCR5380_to_scmd(ncmd);
dsprintk(NDEBUG_QUEUES, instance, "main: tmp=%p target=%d busy=%d lun=%llu\n",
tmp, scmd_id(tmp), hostdata->busy[scmd_id(tmp)],
tmp->device->lun);
/* When we find one, remove it from the issue queue. */
if (!(hostdata->busy[tmp->device->id] &
(1 << (u8)(tmp->device->lun & 0xff)))) {
list_del(&ncmd->list);
dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES,
instance, "main: removed %p from issue queue\n",
tmp);
/* /*
* Attempt to establish an I_T_L nexus here. * Attempt to establish an I_T_L nexus here.
...@@ -855,22 +912,15 @@ static void NCR5380_main(struct work_struct *work) ...@@ -855,22 +912,15 @@ static void NCR5380_main(struct work_struct *work)
* entire unit. * entire unit.
*/ */
if (!NCR5380_select(instance, tmp)) { if (!NCR5380_select(instance, cmd)) {
/* OK or bad target */ dsprintk(NDEBUG_MAIN, instance, "main: selected target %d for command %p\n",
scmd_id(cmd), cmd);
} else { } else {
/* Need to retry */ dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES, instance,
list_add(&ncmd->list, &hostdata->unissued); "main: select failed, returning %p to queue\n", cmd);
dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES, requeue_cmd(instance, cmd);
instance, "main: select() failed, %p returned to issue queue\n", }
tmp);
done = 0;
} }
if (hostdata->connected)
break;
} /* if target/lun is not busy */
} /* for */
} /* if (!hostdata->connected) */
if (hostdata->connected if (hostdata->connected
#ifdef REAL_DMA #ifdef REAL_DMA
&& !hostdata->dmalen && !hostdata->dmalen
...@@ -1853,42 +1903,20 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) { ...@@ -1853,42 +1903,20 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) {
hostdata->connected = NULL; hostdata->connected = NULL;
/* cmd->result &= ~0xffff;
* I'm not sure what the correct thing to do here is : cmd->result |= cmd->SCp.Status;
* cmd->result |= cmd->SCp.Message << 8;
* If the command that just executed is NOT a request
* sense, the obvious thing to do is to set the result
* code to the values of the stored parameters.
*
* If it was a REQUEST SENSE command, we need some way
* to differentiate between the failure code of the original
* and the failure code of the REQUEST sense - the obvious
* case is success, where we fall through and leave the result
* code unchanged.
*
* The non-obvious place is where the REQUEST SENSE failed
*/
if (cmd->cmnd[0] != REQUEST_SENSE)
cmd->result = cmd->SCp.Status | (cmd->SCp.Message << 8);
else if (status_byte(cmd->SCp.Status) != GOOD)
cmd->result = (cmd->result & 0x00ffff) | (DID_ERROR << 16);
if ((cmd->cmnd[0] == REQUEST_SENSE) &&
hostdata->ses.cmd_len) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
hostdata->ses.cmd_len = 0 ;
}
if ((cmd->cmnd[0] != REQUEST_SENSE) && (status_byte(cmd->SCp.Status) == CHECK_CONDITION)) {
scsi_eh_prep_cmnd(cmd, &hostdata->ses, NULL, 0, ~0);
list_add(&ncmd->list, &hostdata->unissued); if (cmd->cmnd[0] == REQUEST_SENSE)
dsprintk(NDEBUG_AUTOSENSE | NDEBUG_QUEUES, complete_cmd(instance, cmd);
instance, "REQUEST SENSE cmd %p added to head of issue queue\n", else {
if (cmd->SCp.Status == SAM_STAT_CHECK_CONDITION ||
cmd->SCp.Status == SAM_STAT_COMMAND_TERMINATED) {
dsprintk(NDEBUG_QUEUES, instance, "autosense: adding cmd %p to tail of autosense queue\n",
cmd); cmd);
hostdata->busy[cmd->device->id] &= ~(1 << (cmd->device->lun & 0xFF)); list_add_tail(&ncmd->list,
} else { &hostdata->autosense);
} else
complete_cmd(instance, cmd); complete_cmd(instance, cmd);
} }
......
drivers/scsi/NCR5380.h
View file @ f27db8eb
...@@ -256,10 +256,12 @@ struct NCR5380_hostdata { ...@@ -256,10 +256,12 @@ struct NCR5380_hostdata {
unsigned char last_message; /* last message OUT */ unsigned char last_message; /* last message OUT */
struct scsi_cmnd *connected; /* currently connected cmnd */ struct scsi_cmnd *connected; /* currently connected cmnd */
struct list_head unissued; /* waiting to be issued */ struct list_head unissued; /* waiting to be issued */
struct list_head autosense; /* priority issue queue */
struct list_head disconnected; /* waiting for reconnect */ struct list_head disconnected; /* waiting for reconnect */
spinlock_t lock; /* protects this struct */ spinlock_t lock; /* protects this struct */
int flags; int flags;
struct scsi_eh_save ses; struct scsi_eh_save ses;
struct scsi_cmnd *sensing;
char info[256]; char info[256];
int read_overruns; /* number of bytes to cut from a int read_overruns; /* number of bytes to cut from a
* transfer to handle chip overruns */ * transfer to handle chip overruns */
......
drivers/scsi/atari_NCR5380.c
View file @ f27db8eb
...@@ -418,6 +418,9 @@ static inline void initialize_SCp(struct scsi_cmnd *cmd) ...@@ -418,6 +418,9 @@ static inline void initialize_SCp(struct scsi_cmnd *cmd)
cmd->SCp.ptr = NULL; cmd->SCp.ptr = NULL;
cmd->SCp.this_residual = 0; cmd->SCp.this_residual = 0;
} }
cmd->SCp.Status = 0;
cmd->SCp.Message = 0;
} }
/** /**
...@@ -661,6 +664,8 @@ static int __init NCR5380_init(struct Scsi_Host *instance, int flags) ...@@ -661,6 +664,8 @@ static int __init NCR5380_init(struct Scsi_Host *instance, int flags)
#endif #endif
spin_lock_init(&hostdata->lock); spin_lock_init(&hostdata->lock);
hostdata->connected = NULL; hostdata->connected = NULL;
hostdata->sensing = NULL;
INIT_LIST_HEAD(&hostdata->autosense);
INIT_LIST_HEAD(&hostdata->unissued); INIT_LIST_HEAD(&hostdata->unissued);
INIT_LIST_HEAD(&hostdata->disconnected); INIT_LIST_HEAD(&hostdata->disconnected);
...@@ -777,6 +782,16 @@ static void complete_cmd(struct Scsi_Host *instance, ...@@ -777,6 +782,16 @@ static void complete_cmd(struct Scsi_Host *instance,
dsprintk(NDEBUG_QUEUES, instance, "complete_cmd: cmd %p\n", cmd); dsprintk(NDEBUG_QUEUES, instance, "complete_cmd: cmd %p\n", cmd);
if (hostdata->sensing == cmd) {
/* Autosense processing ends here */
if ((cmd->result & 0xff) != SAM_STAT_GOOD) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
set_host_byte(cmd, DID_ERROR);
} else
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
hostdata->sensing = NULL;
}
#ifdef SUPPORT_TAGS #ifdef SUPPORT_TAGS
cmd_free_tag(cmd); cmd_free_tag(cmd);
#else #else
...@@ -868,11 +883,76 @@ static inline void maybe_release_dma_irq(struct Scsi_Host *instance) ...@@ -868,11 +883,76 @@ static inline void maybe_release_dma_irq(struct Scsi_Host *instance)
/* Caller does the locking needed to set & test these data atomically */ /* Caller does the locking needed to set & test these data atomically */
if (list_empty(&hostdata->disconnected) && if (list_empty(&hostdata->disconnected) &&
list_empty(&hostdata->unissued) && list_empty(&hostdata->unissued) &&
list_empty(&hostdata->autosense) &&
!hostdata->connected && !hostdata->connected &&
!hostdata->retain_dma_intr) !hostdata->retain_dma_intr)
NCR5380_release_dma_irq(instance); NCR5380_release_dma_irq(instance);
} }
/**
* dequeue_next_cmd - dequeue a command for processing
* @instance: the scsi host instance
*
* Priority is given to commands on the autosense queue. These commands
* need autosense because of a CHECK CONDITION result.
*
* Returns a command pointer if a command is found for a target that is
* not already busy. Otherwise returns NULL.
*/
static struct scsi_cmnd *dequeue_next_cmd(struct Scsi_Host *instance)
{
struct NCR5380_hostdata *hostdata = shost_priv(instance);
struct NCR5380_cmd *ncmd;
struct scsi_cmnd *cmd;
if (list_empty(&hostdata->autosense)) {
list_for_each_entry(ncmd, &hostdata->unissued, list) {
cmd = NCR5380_to_scmd(ncmd);
dsprintk(NDEBUG_QUEUES, instance, "dequeue: cmd=%p target=%d busy=0x%02x lun=%llu\n",
cmd, scmd_id(cmd), hostdata->busy[scmd_id(cmd)], cmd->device->lun);
if (
#ifdef SUPPORT_TAGS
!is_lun_busy(cmd, 1)
#else
!(hostdata->busy[scmd_id(cmd)] & (1 << cmd->device->lun))
#endif
) {
list_del(&ncmd->list);
dsprintk(NDEBUG_QUEUES, instance,
"dequeue: removed %p from issue queue\n", cmd);
return cmd;
}
}
} else {
/* Autosense processing begins here */
ncmd = list_first_entry(&hostdata->autosense,
struct NCR5380_cmd, list);
list_del(&ncmd->list);
cmd = NCR5380_to_scmd(ncmd);
dsprintk(NDEBUG_QUEUES, instance,
"dequeue: removed %p from autosense queue\n", cmd);
scsi_eh_prep_cmnd(cmd, &hostdata->ses, NULL, 0, ~0);
hostdata->sensing = cmd;
return cmd;
}
return NULL;
}
static void requeue_cmd(struct Scsi_Host *instance, struct scsi_cmnd *cmd)
{
struct NCR5380_hostdata *hostdata = shost_priv(instance);
struct NCR5380_cmd *ncmd = scsi_cmd_priv(cmd);
if (hostdata->sensing) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
list_add(&ncmd->list, &hostdata->autosense);
hostdata->sensing = NULL;
} else
list_add(&ncmd->list, &hostdata->unissued);
}
/** /**
* NCR5380_main - NCR state machines * NCR5380_main - NCR state machines
* *
...@@ -889,7 +969,7 @@ static void NCR5380_main(struct work_struct *work) ...@@ -889,7 +969,7 @@ static void NCR5380_main(struct work_struct *work)
struct NCR5380_hostdata *hostdata = struct NCR5380_hostdata *hostdata =
container_of(work, struct NCR5380_hostdata, main_task); container_of(work, struct NCR5380_hostdata, main_task);
struct Scsi_Host *instance = hostdata->host; struct Scsi_Host *instance = hostdata->host;
struct NCR5380_cmd *ncmd, *n; struct scsi_cmnd *cmd;
int done; int done;
/* /*
...@@ -902,33 +982,10 @@ static void NCR5380_main(struct work_struct *work) ...@@ -902,33 +982,10 @@ static void NCR5380_main(struct work_struct *work)
do { do {
done = 1; done = 1;
if (!hostdata->connected) { while (!hostdata->connected &&
dprintk(NDEBUG_MAIN, "scsi%d: not connected\n", HOSTNO); (cmd = dequeue_next_cmd(instance))) {
/*
* Search through the issue_queue for a command destined
* for a target that's not busy.
*/
list_for_each_entry_safe(ncmd, n, &hostdata->unissued,
list) {
struct scsi_cmnd *tmp = NCR5380_to_scmd(ncmd);
u8 lun = tmp->device->lun;
dsprintk(NDEBUG_QUEUES, instance, "main: tmp=%p target=%d busy=%d lun=%d\n",
tmp, scmd_id(tmp), hostdata->busy[scmd_id(tmp)], lun);
/* When we find one, remove it from the issue queue. */
if (
#ifdef SUPPORT_TAGS
!is_lun_busy( tmp, tmp->cmnd[0] != REQUEST_SENSE)
#else
!(hostdata->busy[tmp->device->id] & (1 << lun))
#endif
) {
list_del(&ncmd->list);
dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES,
instance, "main: removed %p from issue queue\n",
tmp);
hostdata->retain_dma_intr++; dsprintk(NDEBUG_MAIN, instance, "main: dequeued %p\n", cmd);
/* /*
* Attempt to establish an I_T_L nexus here. * Attempt to establish an I_T_L nexus here.
...@@ -947,30 +1004,24 @@ static void NCR5380_main(struct work_struct *work) ...@@ -947,30 +1004,24 @@ static void NCR5380_main(struct work_struct *work)
*/ */
#ifdef SUPPORT_TAGS #ifdef SUPPORT_TAGS
cmd_get_tag(tmp, tmp->cmnd[0] != REQUEST_SENSE); cmd_get_tag(cmd, cmd->cmnd[0] != REQUEST_SENSE);
#endif #endif
if (!NCR5380_select(instance, tmp)) { hostdata->retain_dma_intr++;
/* OK or bad target */ if (!NCR5380_select(instance, cmd)) {
dsprintk(NDEBUG_MAIN, instance, "main: selected target %d for command %p\n",
scmd_id(cmd), cmd);
hostdata->retain_dma_intr--; hostdata->retain_dma_intr--;
maybe_release_dma_irq(instance); maybe_release_dma_irq(instance);
} else { } else {
/* Need to retry */ hostdata->retain_dma_intr--;
list_add(&ncmd->list, &hostdata->unissued); dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES, instance,
dsprintk(NDEBUG_MAIN | NDEBUG_QUEUES, "main: select failed, returning %p to queue\n", cmd);
instance, "main: select() failed, %p returned to issue queue\n", requeue_cmd(instance, cmd);
tmp);
#ifdef SUPPORT_TAGS #ifdef SUPPORT_TAGS
cmd_free_tag(tmp); cmd_free_tag(cmd);
#endif #endif
hostdata->retain_dma_intr--;
done = 0;
} }
if (hostdata->connected) }
break;
} /* if target/lun/target queue is not busy */
} /* for issue_queue */
} /* if (!hostdata->connected) */
if (hostdata->connected if (hostdata->connected
#ifdef REAL_DMA #ifdef REAL_DMA
&& !hostdata->dma_len && !hostdata->dma_len
...@@ -2002,47 +2053,20 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) ...@@ -2002,47 +2053,20 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
} }
#endif #endif
/* cmd->result &= ~0xffff;
* I'm not sure what the correct thing to do here is : cmd->result |= cmd->SCp.Status;
* cmd->result |= cmd->SCp.Message << 8;
* If the command that just executed is NOT a request
* sense, the obvious thing to do is to set the result
* code to the values of the stored parameters.
*
* If it was a REQUEST SENSE command, we need some way to
* differentiate between the failure code of the original
* and the failure code of the REQUEST sense - the obvious
* case is success, where we fall through and leave the
* result code unchanged.
*
* The non-obvious place is where the REQUEST SENSE failed
*/
if (cmd->cmnd[0] != REQUEST_SENSE) if (cmd->cmnd[0] == REQUEST_SENSE)
cmd->result = cmd->SCp.Status | (cmd->SCp.Message << 8); complete_cmd(instance, cmd);
else if (status_byte(cmd->SCp.Status) != GOOD) else {
cmd->result = (cmd->result & 0x00ffff) | (DID_ERROR << 16); if (cmd->SCp.Status == SAM_STAT_CHECK_CONDITION ||
cmd->SCp.Status == SAM_STAT_COMMAND_TERMINATED) {
if ((cmd->cmnd[0] == REQUEST_SENSE) && dsprintk(NDEBUG_QUEUES, instance, "autosense: adding cmd %p to tail of autosense queue\n",
hostdata->ses.cmd_len) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
hostdata->ses.cmd_len = 0 ;
}
if ((cmd->cmnd[0] != REQUEST_SENSE) &&
(status_byte(cmd->SCp.Status) == CHECK_CONDITION)) {
scsi_eh_prep_cmnd(cmd, &hostdata->ses, NULL, 0, ~0);
list_add(&ncmd->list, &hostdata->unissued);
dsprintk(NDEBUG_AUTOSENSE | NDEBUG_QUEUES,
instance, "REQUEST SENSE cmd %p added to head of issue queue\n",
cmd); cmd);
#ifdef SUPPORT_TAGS list_add_tail(&ncmd->list,
cmd_free_tag(cmd); &hostdata->autosense);
#else } else
hostdata->busy[cmd->device->id] &= ~(1 << cmd->device->lun);
#endif
} else {
complete_cmd(instance, cmd); complete_cmd(instance, cmd);
} }
...@@ -2533,6 +2557,15 @@ static int NCR5380_bus_reset(struct scsi_cmnd *cmd) ...@@ -2533,6 +2557,15 @@ static int NCR5380_bus_reset(struct scsi_cmnd *cmd)
dsprintk(NDEBUG_ABORT, instance, "reset aborted a connected command\n"); dsprintk(NDEBUG_ABORT, instance, "reset aborted a connected command\n");
hostdata->connected = NULL; hostdata->connected = NULL;
if (hostdata->sensing) {
complete_cmd(instance, hostdata->sensing);
hostdata->sensing = NULL;
}
if (!list_empty(&hostdata->autosense))
dsprintk(NDEBUG_ABORT, instance, "reset aborted autosense list\n");
INIT_LIST_HEAD(&hostdata->autosense);
if (!list_empty(&hostdata->unissued)) if (!list_empty(&hostdata->unissued))
dsprintk(NDEBUG_ABORT, instance, "reset aborted unissued list\n"); dsprintk(NDEBUG_ABORT, instance, "reset aborted unissued list\n");
INIT_LIST_HEAD(&hostdata->unissued); INIT_LIST_HEAD(&hostdata->unissued);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7