Commit f28510d3 authored by Christoph Lameter's avatar Christoph Lameter Committed by Pekka Enberg

slab: Only define slab_error for DEBUG

On Tue, 11 Sep 2012, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
>
> mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
>
> Introduced by commit 945cf2b6 ("mm/sl[aou]b: Extract a common
> function for kmem_cache_destroy").  All uses of slab_error() are now
> guarded by DEBUG.

There is no use case left for slab builds without DEBUG.
Signed-off-by: default avatarChristoph Lameter <cl@linux.com>
Signed-off-by: default avatarPekka Enberg <penberg@kernel.org>
parent 9df53b15
...@@ -803,6 +803,7 @@ static void cache_estimate(unsigned long gfporder, size_t buffer_size, ...@@ -803,6 +803,7 @@ static void cache_estimate(unsigned long gfporder, size_t buffer_size,
*left_over = slab_size - nr_objs*buffer_size - mgmt_size; *left_over = slab_size - nr_objs*buffer_size - mgmt_size;
} }
#if DEBUG
#define slab_error(cachep, msg) __slab_error(__func__, cachep, msg) #define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)
static void __slab_error(const char *function, struct kmem_cache *cachep, static void __slab_error(const char *function, struct kmem_cache *cachep,
...@@ -812,6 +813,7 @@ static void __slab_error(const char *function, struct kmem_cache *cachep, ...@@ -812,6 +813,7 @@ static void __slab_error(const char *function, struct kmem_cache *cachep,
function, cachep->name, msg); function, cachep->name, msg);
dump_stack(); dump_stack();
} }
#endif
/* /*
* By default on NUMA we use alien caches to stage the freeing of * By default on NUMA we use alien caches to stage the freeing of
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment